Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 945813002: Change bit pattern of hole nan to reflect different sNan encoding on mips HW. (Closed)

Created:
5 years, 10 months ago by dusmil.imgtec
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Change bit pattern of hole nan to reflect different sNan encoding on mips HW. TEST= BUG= Committed: https://crrev.com/4e946e3e23bbb78d88548d03543bb40af5a87ef9 Cr-Commit-Position: refs/heads/master@{#26784}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M src/globals.h View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
dusmil.imgtec
PTAL.
5 years, 10 months ago (2015-02-20 16:27:12 UTC) #2
Benedikt Meurer
lgtm
5 years, 10 months ago (2015-02-20 18:29:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/945813002/1
5 years, 10 months ago (2015-02-20 18:30:27 UTC) #5
commit-bot: I haz the power
Failed to apply the patch.
5 years, 10 months ago (2015-02-20 19:09:19 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 19:09:24 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 19:09:43 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4e946e3e23bbb78d88548d03543bb40af5a87ef9
Cr-Commit-Position: refs/heads/master@{#26784}

Powered by Google App Engine
This is Rietveld 408576698