Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1379)

Issue 945803005: Enable override keyword for GCC versions >= 4.7 (Closed)

Created:
5 years, 10 months ago by djsollen
Modified:
5 years, 10 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Enable override keyword for GCC versions >= 4.7 Committed: https://skia.googlesource.com/skia/+/7ff705023df8f56cfdc3d3df215e96f7ac5caee7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M include/core/SkPostConfig.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
djsollen
5 years, 10 months ago (2015-02-20 18:48:06 UTC) #2
djsollen
5 years, 10 months ago (2015-02-20 18:48:16 UTC) #4
mtklein
lgtm
5 years, 10 months ago (2015-02-20 18:59:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/945803005/1
5 years, 10 months ago (2015-02-20 19:01:39 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 20:35:43 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7ff705023df8f56cfdc3d3df215e96f7ac5caee7

Powered by Google App Engine
This is Rietveld 408576698