Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1268)

Unified Diff: extensions/common/manifest_constants.cc

Issue 945743003: Improve error message for failing code insertion on about:-URLs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add origin to error message Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/manifest_constants.h ('k') | extensions/renderer/programmatic_script_injector.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/manifest_constants.cc
diff --git a/extensions/common/manifest_constants.cc b/extensions/common/manifest_constants.cc
index 1c51334cba975b42b1c3a280e75023ef7179c875..8b3e6a4060b3a23bd15c2b6362549fe435b4ec3f 100644
--- a/extensions/common/manifest_constants.cc
+++ b/extensions/common/manifest_constants.cc
@@ -250,6 +250,9 @@ const char kBackgroundPermissionNeeded[] =
"permission.";
const char kBackgroundRequiredForPlatformApps[] =
"Packaged apps must have a background page or background scripts.";
+const char kCannotAccessAboutUrl[] =
+ "Cannot access \"*\" at origin \"*\". Extension must have permission to "
+ "access the frame's origin, and matchAboutBlank must be true.";
const char kCannotAccessChromeUrl[] = "Cannot access a chrome:// URL";
const char kCannotAccessExtensionUrl[] =
"Cannot access a chrome-extension:// URL of different extension";
« no previous file with comments | « extensions/common/manifest_constants.h ('k') | extensions/renderer/programmatic_script_injector.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698