Issue 9457: Fix lint issues....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9457: Fix lint issues.... (Closed)

Created:
12 years, 1 month ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Christian Plesner Hansen

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/regexp2000/

Visibility:
Public.

Description

Fix lint issues. Add some new bytecodes that we wil be needing (no tests yet). Committed: http://code.google.com/p/v8/source/detail?r=707

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+185 lines, -52 lines)			Patch
M	src/assembler-re2k.h	View	4 chunks	+19 lines, -5 lines	1 comment	Download
M	src/assembler-re2k.cc	View	5 chunks	+65 lines, -8 lines	0 comments	Download
M	src/bytecodes-re2k.h	View	1 chunk	+28 lines, -24 lines	0 comments	Download
M	src/interpreter-re2k.h	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	src/interpreter-re2k.cc	View	5 chunks	+64 lines, -10 lines	0 comments	Download
M	src/regexp-codegen.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-regexp.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Christian Plesner Hansen

12 years, 1 month ago (2008-11-06 15:42:58 UTC) #2

Lookin' good.

http://codereview.chromium.org/9457/diff/1/8
File src/assembler-re2k.h (right):

http://codereview.chromium.org/9457/diff/1/8#newcode76
Line 76: // Checks a register for equal, less than or equal, less than, greater
than
We only need two of these, LT and GEQ.

Expand Messages | Collapse Messages