Issue 22288. Rename named parameters in hierarchy.

pkg/analysis_server/test/services/refactoring/rename_local_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.services.refactoring.rename_local;
 
 import 'package:analysis_server/src/protocol.dart';
+import 'package:analysis_server/src/services/correction/status.dart';
 import 'package:unittest/unittest.dart';
 
 import '../../reflective_tests.dart';
 import 'abstract_rename.dart';
-import 'package:analysis_server/src/services/correction/status.dart';
-
 
 main() {
   groupSep = ' | ';
   runReflectiveTests(RenameLocalTest);
 }
 
-
 @reflectiveTest
 class RenameLocalTest extends RenameRefactoringTest {
   test_checkFinalConditions_hasLocalFunction_after() async {
     indexTestUnit('''
 main() {
   int test = 0;
   newName() => 1;
 }
 ''');
     createRenameRefactoringAtString('test = 0');
@@ skipping 109 matching lines @@
     refactoring.newName = 'newName';
     RefactoringStatus status = await refactoring.checkFinalConditions();
     assertRefactoringStatus(
         status,
         RefactoringProblemSeverity.ERROR,
         expectedMessage: 'Usage of field "A.newName" declared in "test.dart" '
             'will be shadowed by renamed local variable.',
         expectedContextSearch: 'newName);');
   }
 
+  test_checkFinalConditions_shadows_classMember_namedParameter() async {
+    indexTestUnit('''
+class A {
+  foo({test: 1}) {
+  }
+}
+class B extends A {
+  var newName = 1;
+  foo({test: 2}) {
+    print(newName);
+  }
+}
+''');
+    createRenameRefactoringAtString('test: 1}');
+    // check status
+    refactoring.newName = 'newName';
+    RefactoringStatus status = await refactoring.checkFinalConditions();
+    assertRefactoringStatus(
+        status,
+        RefactoringProblemSeverity.ERROR,
+        expectedMessage: 'Usage of field "B.newName" declared in "test.dart" '
+            'will be shadowed by renamed parameter.',
+        expectedContextSearch: 'newName);');
+  }
+
   test_checkFinalConditions_shadows_classMemberOK_qualifiedReference() {
     indexTestUnit('''
 class A {
   var newName = 1;
   main() {
     var test = 0;
     print(this.newName);
   }
 }
 ''');
@@ skipping 244 matching lines @@
   newName = 1;
   newName += 2;
   print(newName);
 }
 main() {
   myFunction(newName: 2);
 }
 ''');
   }
 
-  test_createChange_parameter_namedInOtherFile() async {
+  test_createChange_parameter_named_inOtherFile() async {
     indexTestUnit('''
 class A {
   A({test});
 }
 ''');
     indexUnit('/test2.dart', '''
 import 'test.dart';
 main() {
   new A(test: 2);
 }
 ''');
     // configure refactoring
     createRenameRefactoringAtString('test});');
     expect(refactoring.refactoringName, 'Rename Parameter');
     refactoring.newName = 'newName';
     // validate change
     await assertSuccessfulRefactoring('''
 class A {
   A({newName});
 }
 ''');
     assertFileChangeResult('/test2.dart', '''
 import 'test.dart';
 main() {
   new A(newName: 2);
 }
 ''');
   }
 
+  test_createChange_parameter_named_updateHierarchy() async {
+    indexUnit('/test2.dart', '''
+library test2;
+class A {
+  void foo({int test: 1}) {
+    print(test);
+  }
+}
+class B extends A {
+  void foo({int test: 2}) {
+    print(test);
+  }
+}
+''');
+    indexTestUnit('''
+import 'test2.dart';
+main() {
+  new A().foo(test: 10);
+  new B().foo(test: 20);
+  new C().foo(test: 30);
+}
+class C extends A {
+  void foo({int test: 3}) {
+    print(test);
+  }
+}
+''');
+    // configure refactoring
+    createRenameRefactoringAtString('test: 20');
+    expect(refactoring.refactoringName, 'Rename Parameter');
+    refactoring.newName = 'newName';
+    // validate change
+    await assertSuccessfulRefactoring('''
+import 'test2.dart';
+main() {
+  new A().foo(newName: 10);
+  new B().foo(newName: 20);
+  new C().foo(newName: 30);
+}
+class C extends A {
+  void foo({int newName: 3}) {
+    print(newName);
+  }
+}
+''');
+    assertFileChangeResult('/test2.dart', '''
+library test2;
+class A {
+  void foo({int newName: 1}) {
+    print(newName);
+  }
+}
+class B extends A {
+  void foo({int newName: 2}) {
+    print(newName);
+  }
+}
+''');
+  }
+
   test_oldName() {
     indexTestUnit('''
 main() {
   int test = 0;
 }
 ''');
     // configure refactoring
     createRenameRefactoringAtString('test = 0');
     // old name
     expect(refactoring.oldName, 'test');
   }
 }