Make wininet.dll delay load

Make wininet.dll delay load

This is used only in the utility process but loading it causes
conflicts with AppContainers in the renderer.

BUG=460679
R=scottmg@chromium.org,thestig@chromium.org
TBR=thestig@chromium.org

Committed: https://crrev.com/05b47b88e7bb2357ff5ad6ffc24ffdb3482b762c
Cr-Commit-Position: refs/heads/master@{#318123}

[jschuh, 2015-02-24 22:02:27]

ptal. Either the nesting needs to be this deep or I cargo culted it.

[scottmg, 2015-02-24 22:06:16]

Should change chrome\utility\build.gn probably too.

https://codereview.chromium.org/945663004/diff/1/chrome/chrome_utility.gypi
File chrome/chrome_utility.gypi (right):

https://codereview.chromium.org/945663004/diff/1/chrome/chrome_utility.gypi#n...
chrome/chrome_utility.gypi:156: ['OS=="win"', {
What does this have to do with enable_extensions==1?

[scottmg, 2015-02-24 22:08:03]

https://codereview.chromium.org/945663004/diff/1/chrome/chrome_utility.gypi
File chrome/chrome_utility.gypi (right):

https://codereview.chromium.org/945663004/diff/1/chrome/chrome_utility.gypi#n...
chrome/chrome_utility.gypi:161: # Prevent this from loading in the renderer
process.
also please add a link to the appcontainer bug here

[scottmg, 2015-02-25 18:04:56]

lgtm

https://codereview.chromium.org/945663004/diff/20001/chrome/utility/BUILD.gn
File chrome/utility/BUILD.gn (right):

https://codereview.chromium.org/945663004/diff/20001/chrome/utility/BUILD.gn#...
chrome/utility/BUILD.gn:53: ldflags = [ "/DELAYLOAD:wininet.dll" ]
I'm not sure why this doesn't work. I suspect because it's on a lib, not an
executable/dll? But since it matches gyp it might be a gn problem, and since
there will be an obvious failure we can figure it out later.

[jschuh, 2015-02-25 18:07:44]

https://codereview.chromium.org/945663004/diff/1/chrome/chrome_utility.gypi
File chrome/chrome_utility.gypi (right):

https://codereview.chromium.org/945663004/diff/1/chrome/chrome_utility.gypi#n...
chrome/chrome_utility.gypi:156: ['OS=="win"', {
On 2015/02/24 22:06:16, scottmg wrote:
> What does this have to do with enable_extensions==1?

Nothing. I put it in the wrong place because I wasn't paying attention. :)

https://codereview.chromium.org/945663004/diff/20001/chrome/utility/BUILD.gn
File chrome/utility/BUILD.gn (right):

https://codereview.chromium.org/945663004/diff/20001/chrome/utility/BUILD.gn#...
chrome/utility/BUILD.gn:53: ldflags = [ "/DELAYLOAD:wininet.dll" ]
On 2015/02/25 18:04:56, scottmg wrote:
> I'm not sure why this doesn't work. I suspect because it's on a lib, not an
> executable/dll? But since it matches gyp it might be a gn problem, and since
> there will be an obvious failure we can figure it out later.

Excellent. I place the entire burden on you. :)

[jschuh, 2015-02-25 18:41:05]

The CQ bit was checked by jschuh@chromium.org

[commit-bot: I haz the power, 2015-02-25 18:41:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/945663004/20001

[commit-bot: I haz the power, 2015-02-25 18:59:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-25 18:59:50]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jschuh, 2015-02-25 20:46:30]

Adding thestig@ as a TBR for BUILD.gn owner, but scottmg@ already reviewed the
content.

[jschuh, 2015-02-25 20:46:34]

The CQ bit was checked by jschuh@chromium.org

[commit-bot: I haz the power, 2015-02-25 20:47:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/945663004/20001

[commit-bot: I haz the power, 2015-02-25 21:41:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-25 21:42:40]

Patchset 2 (id:??) landed as
https://crrev.com/05b47b88e7bb2357ff5ad6ffc24ffdb3482b762c
Cr-Commit-Position: refs/heads/master@{#318123}

[brettw, 2015-02-25 23:35:04]

brettw@chromium.org changed reviewers:
+ brettw@chromium.org

[brettw, 2015-02-25 23:35:05]

https://codereview.chromium.org/945663004/diff/20001/chrome/utility/BUILD.gn
File chrome/utility/BUILD.gn (right):

https://codereview.chromium.org/945663004/diff/20001/chrome/utility/BUILD.gn#...
chrome/utility/BUILD.gn:53: ldflags = [ "/DELAYLOAD:wininet.dll" ]
See "gn help ldflags" for how this works and what you should do instead.

[scottmg, 2015-02-25 23:40:49]

[ FWIW, it doesn't matter yet because lockdown (what this is needed for)
requires multi dll first. But thanks for the reminder. ]

On Wed, Feb 25, 2015 at 3:35 PM, <brettw@chromium.org> wrote:

>
> https://codereview.chromium.org/945663004/diff/20001/
> chrome/utility/BUILD.gn
> File chrome/utility/BUILD.gn (right):
>
> https://codereview.chromium.org/945663004/diff/20001/
> chrome/utility/BUILD.gn#newcode53
> chrome/utility/BUILD.gn:53: ldflags = [ "/DELAYLOAD:wininet.dll" ]
> See "gn help ldflags" for how this works and what you should do instead.
>
>
> https://codereview.chromium.org/945663004/
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[jschuh, 2015-02-26 01:37:49]

Want me to just revert the GN change in a follow-up? Or I can add it to the
ldflags for chrome.dll, along with a comment and a todo.

[brettw, 2015-02-26 17:55:48]

On 2015/02/26 01:37:49, jschuh wrote:
> Want me to just revert the GN change in a follow-up? Or I can add it to the
> ldflags for chrome.dll, along with a comment and a todo.

chrome.dll flags sgtm

[scottmg, 2015-02-26 19:04:08]

https://code.google.com/p/chromium/issues/detail?id=462071

On Thu, Feb 26, 2015 at 9:55 AM, <brettw@chromium.org> wrote:

> On 2015/02/26 01:37:49, jschuh wrote:
>
>> Want me to just revert the GN change in a follow-up? Or I can add it to
>> the
>> ldflags for chrome.dll, along with a comment and a todo.
>>
>
> chrome.dll flags sgtm
>
>
> https://codereview.chromium.org/945663004/
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.