Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 945663003: Serve skydb on localhost instead of 0.0.0.0. (Closed)

Created:
5 years, 10 months ago by ppi
Modified:
5 years, 10 months ago
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Serve skydb on localhost instead of 0.0.0.0. This patch makes skydb http server available only for local connections. BUG=460908 R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/bba5a32c1e1d079cce516ccc351d7c0a5a10c0dc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M sky/tools/debugger/debugger.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ppi
Hi Adam or Eric, ptal.
5 years, 10 months ago (2015-02-24 16:47:10 UTC) #2
abarth-chromium
lgtm
5 years, 10 months ago (2015-02-24 17:09:35 UTC) #3
ppi
5 years, 10 months ago (2015-02-24 17:10:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bba5a32c1e1d079cce516ccc351d7c0a5a10c0dc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698