Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 945633003: win vs2015: avoid some variable shadowing warnings in crypto/p224 (Closed)

Created:
5 years, 10 months ago by scottmg
Modified:
5 years, 10 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

win vs2015: avoid some variable shadowing warnings in crypto/p224 e.g. d:\src\cr2\src\crypto\p224.cc(478): error C2220: warning treated as error - no 'object' file generated d:\src\cr2\src\crypto\p224.cc(478): warning C4456: declaration of 'j' hides previous local declaration d:\src\cr2\src\crypto\p224.cc(447): note: see declaration of 'j' d:\src\cr2\src\crypto\p224.cc(498): warning C4456: declaration of 'i' hides previous local declaration d:\src\cr2\src\crypto\p224.cc(447): note: see declaration of 'i' d:\src\cr2\src\crypto\p224.cc(516): warning C4456: declaration of 'i' hides previous local declaration d:\src\cr2\src\crypto\p224.cc(447): note: see declaration of 'i' d:\src\cr2\src\crypto\p224.cc(526): warning C4456: declaration of 'i' hides previous local declaration d:\src\cr2\src\crypto\p224.cc(447): note: see declaration of 'i' d:\src\cr2\src\crypto\p224.cc(694): warning C4458: declaration of 'x' hides class member d:\src\cr2\src\crypto\p224.h(35): note: see declaration of 'crypto::p224::Point::x' d:\src\cr2\src\crypto\p224.cc(694): warning C4458: declaration of 'y' hides class member d:\src\cr2\src\crypto\p224.h(35): note: see declaration of 'crypto::p224::Point::y' R=rsleevi@chromium.org BUG=440500 Committed: https://crrev.com/cb6a123e432e617052721ef43823fd60b002284e Cr-Commit-Position: refs/heads/master@{#317398}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M crypto/p224.cc View 6 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scottmg
5 years, 10 months ago (2015-02-20 04:56:01 UTC) #1
Ryan Sleevi
lgtm
5 years, 10 months ago (2015-02-20 20:00:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/945633003/1
5 years, 10 months ago (2015-02-20 20:25:46 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 20:59:41 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 21:00:30 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb6a123e432e617052721ef43823fd60b002284e
Cr-Commit-Position: refs/heads/master@{#317398}

Powered by Google App Engine
This is Rietveld 408576698