Add a histogram to debug metrics entropy source use.

Add a histogram to debug metrics entropy source use.

BUG=461565
Committed: https://crrev.com/20fd1dbe8070b9c0028ce524823b267048c8df0b
Cr-Commit-Position: refs/heads/master@{#318085}

[Alexei Svitkine (slow), 2015-02-24 22:56:22]

Patchset #1 (id:1) has been deleted

[Alexei Svitkine (slow), 2015-02-24 22:56:36]

asvitkine@chromium.org changed reviewers:
+ rkaplow@chromium.org

[rkaplow, 2015-02-24 23:03:25]

https://codereview.chromium.org/945603003/diff/20001/components/metrics/metri...
File components/metrics/metrics_state_manager.h (right):

https://codereview.chromium.org/945603003/diff/20001/components/metrics/metri...
components/metrics/metrics_state_manager.h:120: // Updates
|entropy_source_returned_| with |type| if the current value is
nit: change if to iff to make it clear nothing happens if it's not NONE

[rkaplow, 2015-02-24 23:03:30]

lgtm

[Alexei Svitkine (slow), 2015-02-24 23:12:02]

I'll fix comment tomorrow if you don't mind. Cqing now so we can start
getting data sooner.
On Feb 24, 2015 6:03 PM, <rkaplow@chromium.org> wrote:

> lgtm
>
>
>
> https://codereview.chromium.org/945603003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Alexei Svitkine (slow), 2015-02-24 23:12:14]

The CQ bit was checked by asvitkine@chromium.org

[commit-bot: I haz the power, 2015-02-24 23:13:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/945603003/20001

[commit-bot: I haz the power, 2015-02-24 23:13:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-24 23:13:33]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Alexei Svitkine (slow), 2015-02-24 23:32:55]

Oh, right. Forgot about that part. I guess I'll fix comment tomorrow and
have Jesse review.
On Feb 24, 2015 6:13 PM, <commit-bot@chromium.org> wrote:

> No LGTM from a valid reviewer yet. Only full committers are accepted.
> Even if an LGTM may have been provided, it was from a non-committer,
> _not_ a full super star committer.
> See http://www.chromium.org/getting-involved/become-a-committer
> Note that this has nothing to do with OWNERS files.
>
> https://codereview.chromium.org/945603003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Alexei Svitkine (slow), 2015-02-25 16:12:57]

asvitkine@chromium.org changed reviewers:
+ jwd@google.com

[Alexei Svitkine (slow), 2015-02-25 16:12:58]

+jwd

Jesse, I need an lgtm from a committer, could you take a look? Thanks.

https://codereview.chromium.org/945603003/diff/20001/components/metrics/metri...
File components/metrics/metrics_state_manager.h (right):

https://codereview.chromium.org/945603003/diff/20001/components/metrics/metri...
components/metrics/metrics_state_manager.h:120: // Updates
|entropy_source_returned_| with |type| if the current value is
On 2015/02/24 23:03:24, rkaplow wrote:
> nit: change if to iff to make it clear nothing happens if it's not NONE

Done.

[jwd, 2015-02-25 16:32:48]

jwd@chromium.org changed reviewers:
+ jwd@chromium.org
- jwd@google.com

[jwd, 2015-02-25 16:32:49]

lgtm

[Alexei Svitkine (slow), 2015-02-25 16:33:11]

The CQ bit was checked by asvitkine@chromium.org

[Alexei Svitkine (slow), 2015-02-25 16:33:11]

The patchset sent to the CQ was uploaded after l-g-t-m from rkaplow@chromium.org
Link to the patchset: https://codereview.chromium.org/945603003/#ps40001 (title:
" ")

[commit-bot: I haz the power, 2015-02-25 16:33:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/945603003/40001

[commit-bot: I haz the power, 2015-02-25 19:06:36]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-02-25 19:07:11]

Patchset 2 (id:??) landed as
https://crrev.com/20fd1dbe8070b9c0028ce524823b267048c8df0b
Cr-Commit-Position: refs/heads/master@{#318085}