Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 945553002: Allow LLVM TOOLS_ONLY builds w/ subzero, localize noirt/srpc (Closed)

Created:
5 years, 10 months ago by jvoung (off chromium)
Modified:
5 years, 9 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-llvm.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow LLVM TOOLS_ONLY builds w/ subzero, localize noirt/srpc We use TOOLS_ONLY in the sandboxed build, so make it aware of subzero. Localize the noirt, and libsrpc, etc. Makefile changes to pnacl-llc only. Goes w/ build script change https://codereview.chromium.org/945473003/ BUG= https://code.google.com/p/nativeclient/issues/detail?id=4091 R=dschuff@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-llvm.git;a=commit;h=8fbe86226a8671cbfa9adeb43a66c02181adc5c9

Patch Set 1 #

Patch Set 2 : lower localmod #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M Makefile.rules View 1 2 1 chunk +0 lines, -12 lines 0 comments Download
M tools/Makefile View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M tools/pnacl-llc/Makefile View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jvoung (off chromium)
5 years, 10 months ago (2015-02-19 23:11:44 UTC) #2
Derek Schuff
lgtm
5 years, 10 months ago (2015-02-19 23:23:20 UTC) #3
jvoung (off chromium)
5 years, 9 months ago (2015-03-02 22:23:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
8fbe86226a8671cbfa9adeb43a66c02181adc5c9 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698