Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issue 945473003: Add subzero nexe to the pnacl translator build (NaCl build scripts). (Closed)

Created:
5 years, 10 months ago by jvoung (off chromium)
Modified:
5 years, 9 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Add subzero nexe to the pnacl translator build (NaCl build scripts). Also update COMPONENT revisions to bring in LLVM and Subzero Makefile changes: https://codereview.chromium.org/945553002/ https://codereview.chromium.org/937283002/ Limited to a x86-32 nexe. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4091 (Subzero change included a workaround for method ptrs with -O3): BUG= https://code.google.com/p/nativeclient/issues/detail?id=3857 R=dschuff@chromium.org Committed: https://chromium.googlesource.com/native_client/src/native_client/+/cfe49423b22831d1d1d2bad35ddd0917a78b4cd9

Patch Set 1 #

Patch Set 2 : limit to x86-32 #

Patch Set 3 : typo #

Patch Set 4 : rebase #

Patch Set 5 : update revs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -20 lines) Patch
M pnacl/COMPONENT_REVISIONS View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M pnacl/build.sh View 1 2 3 4 chunks +29 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jvoung (off chromium)
5 years, 10 months ago (2015-02-19 23:12:42 UTC) #2
Derek Schuff
lgtm
5 years, 10 months ago (2015-02-19 23:22:04 UTC) #3
jvoung (off chromium)
rebased to rename llvm2ice to pnacl-sz, NACL_SANDBOX->PNACL_BROWSER_TRANSLATOR, and added the COMPONENT_REVISION change
5 years, 9 months ago (2015-03-02 22:30:53 UTC) #4
jvoung (off chromium)
5 years, 9 months ago (2015-03-03 00:59:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
cfe49423b22831d1d1d2bad35ddd0917a78b4cd9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698