Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 945423002: Change structure of pointers to latest versions of apps in Google Storage. (Closed)

Created:
5 years, 10 months ago by blundell
Modified:
5 years, 10 months ago
Reviewers:
jamesr, qsr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Change structure of pointers to latest versions of apps in Google Storage. The goal of this CL is to allow a server app to serve apps that are stored in gs://mojo/services without having to be aware of what repo those apps were published out of. To that end, this CL changes the monolithic LATEST file that was previously being used to indicate the latest version of services to instead be a per-app file whose contents are the URL where the current version of the app can be found. We will then be able to have the server app serve e.g. HTMLViewer simply by having the Chromium upload script write the html_viewer_location file in the right place. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/18238833b4ca3c5518a5401526d0de45cacefbea

Patch Set 1 #

Patch Set 2 : Self-review #

Patch Set 3 : Self-review #

Total comments: 2

Patch Set 4 : Response to review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -10 lines) Patch
M mojo/tools/upload_binaries.py View 1 2 3 3 chunks +23 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
blundell
5 years, 10 months ago (2015-02-23 10:20:16 UTC) #2
qsr
https://codereview.chromium.org/945423002/diff/40001/mojo/tools/upload_binaries.py File mojo/tools/upload_binaries.py (right): https://codereview.chromium.org/945423002/diff/40001/mojo/tools/upload_binaries.py#newcode90 mojo/tools/upload_binaries.py:90: app_name = os.path.splitext(app_binary_name)[0] I would write this as app_name, ...
5 years, 10 months ago (2015-02-23 10:52:39 UTC) #3
qsr
LGTM with previous nit.
5 years, 10 months ago (2015-02-23 10:52:52 UTC) #4
blundell
https://codereview.chromium.org/945423002/diff/40001/mojo/tools/upload_binaries.py File mojo/tools/upload_binaries.py (right): https://codereview.chromium.org/945423002/diff/40001/mojo/tools/upload_binaries.py#newcode90 mojo/tools/upload_binaries.py:90: app_name = os.path.splitext(app_binary_name)[0] On 2015/02/23 10:52:39, qsr wrote: > ...
5 years, 10 months ago (2015-02-23 11:06:55 UTC) #6
blundell
Committed patchset #4 (id:60001) manually as 18238833b4ca3c5518a5401526d0de45cacefbea (presubmit successful).
5 years, 10 months ago (2015-02-23 11:08:15 UTC) #7
jamesr
What information are we encoding here that doesn't already exist in the URL?
5 years, 10 months ago (2015-02-24 21:53:28 UTC) #9
jamesr
5 years, 10 months ago (2015-02-24 22:06:52 UTC) #10
Message was sent while issue was closed.
Gah sorry, wrong patch.

Powered by Google App Engine
This is Rietveld 408576698