Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 945403008: Invalidate property cells for non-existent properties properly. (Closed)

Created:
5 years, 10 months ago by Dmitry Lomov (no reviews)
Modified:
5 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Invalidate property cells for non-existent properties properly. R=verwaest@chromium.org BUG=v8:3914 LOG=N Committed: https://crrev.com/675f7d2d5aeba79374d5d121d425502e44e2e7dc Cr-Commit-Position: refs/heads/master@{#26822}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Patch for landing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M src/objects.cc View 1 1 chunk +9 lines, -2 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Dmitry Lomov (no reviews)
PTAL.
5 years, 10 months ago (2015-02-24 12:04:30 UTC) #1
Toon Verwaest
lgtm with comment https://codereview.chromium.org/945403008/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/945403008/diff/1/src/objects.cc#newcode15341 src/objects.cc:15341: // BUG3914: if property value was ...
5 years, 10 months ago (2015-02-24 12:27:52 UTC) #2
Dmitry Lomov (no reviews)
Comment addressed, landing.
5 years, 10 months ago (2015-02-24 12:29:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/945403008/20001
5 years, 10 months ago (2015-02-24 12:29:41 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-24 13:05:04 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 13:05:20 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/675f7d2d5aeba79374d5d121d425502e44e2e7dc
Cr-Commit-Position: refs/heads/master@{#26822}

Powered by Google App Engine
This is Rietveld 408576698