tools/telemetry/telemetry/page/actions/scroll.py - Issue 945393002: Adding support for diagonal scrolling to telemetry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/actions/scroll.py

Issue 945393002: Adding support for diagonal scrolling to telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed a bug which would take the minimum of two numbers (even though one would likely be negative).… Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/page/actions/scroll.py

diff --git a/tools/telemetry/telemetry/page/actions/scroll.py b/tools/telemetry/telemetry/page/actions/scroll.py

index ab80058f9688051f86417a0d104fe61931e8368b..61f2fc8673826035e38ee21a55985ea82cbac1a5 100644

--- a/tools/telemetry/telemetry/page/actions/scroll.py

+++ b/tools/telemetry/telemetry/page/actions/scroll.py

@@ -14,7 +14,9 @@ class ScrollAction(page_action.PageAction):

distance=None, distance_expr=None,

speed_in_pixels_per_second=800, use_touch=False):

super(ScrollAction, self).__init__()

- if direction not in ['down', 'up', 'left', 'right']:

+ if direction not in ['down', 'up', 'left', 'right',

+ 'downleft', 'downright',

+ 'upleft', 'upright']:

raise page_action.PageActionNotSupported(

'Invalid scroll direction: %s' % self.direction)

self._selector = selector