Issue 945373002: Refocus app list search box when dialogs are closed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 945373002: Refocus app list search box when dialogs are closed. (Closed)

Created:
5 years, 10 months ago by calamity

Modified:
5 years, 10 months ago

Reviewers:
Matt Giuca

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Refocus app list search box when dialogs are closed. This CL fixes an issue where closing dialog boxes in the app list would not restore focus to the search box. This is fixed by refocusing the search box when the app list overlay is hidden. BUG=450922 Committed: https://crrev.com/05cdce00a6b2909deccc57ef54858c5a867f7885 Cr-Commit-Position: refs/heads/master@{#317727}

Patch Set 1 #

Patch Set 2 : add_Test #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -0 lines)			Patch
	M	ui/app_list/views/app_list_view.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	ui/app_list/views/app_list_view_unittest.cc	View	1	3 chunks	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/945373002/20001

5 years, 10 months ago (2015-02-24 01:12:26 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-24 01:36:14 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/05cdce00a6b2909deccc57ef54858c5a867f7885
Cr-Commit-Position: refs/heads/master@{#317727}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages