Issue 945363006: Remove setPageScaleFactor from InternalSettings::resetToConsistentState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 945363006: Remove setPageScaleFactor from InternalSettings::resetToConsistentState. (Closed)

Created:
5 years, 10 months ago by bokan

Modified:
5 years, 10 months ago

Reviewers:
pdr.

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove setPageScaleFactor from InternalSettings::resetToConsistentState. PageScaleFactor isn't an InternalSetting so it doesn't make sense to reset it here. The PageScaleFactor is reset in Internals::resetToConsistentState so this should have no effect on current tests as these two are always called together. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190689

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	Source/core/testing/InternalSettings.cpp	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

bokan

Along with https://codereview.chromium.org/944083004/ there were 3 places where we were resetting page scale. This call ...

5 years, 10 months ago (2015-02-23 18:38:58 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/945363006/1

5 years, 10 months ago (2015-02-23 19:15:10 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-23 20:52:54 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190689

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages