extensions/browser/guest_view/web_view/web_view_guest.cc - Issue 945333002: Implement <webview> droplink event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/web_view_guest.cc

Issue 945333002: Implement <webview> droplink event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cleanup_bpe

Patch Set: Addressed Istiaque's comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/guest_view/web_view/web_view_guest.cc

diff --git a/extensions/browser/guest_view/web_view/web_view_guest.cc b/extensions/browser/guest_view/web_view/web_view_guest.cc

index eacef42e6fe5200bde185713101f503d660a4bc4..8b9bfb0391399deca42ff8a2b7724d372417e117 100644

--- a/extensions/browser/guest_view/web_view/web_view_guest.cc

+++ b/extensions/browser/guest_view/web_view/web_view_guest.cc

@@ -274,6 +274,13 @@ void WebViewGuest::DidAttachToEmbedder() {

ApplyAttributes(*attach_params());

}

+void WebViewGuest::DidDropLink(const GURL& url) {

+ scoped_ptr<base::DictionaryValue> args(new base::DictionaryValue());

+ args->SetString(guestview::kUrl, url.spec());

+ DispatchEventToView(

+ new GuestViewBase::Event(webview::kEventDropLink, args.Pass()));

void WebViewGuest::DidInitialize(const base::DictionaryValue& create_params) {

script_executor_.reset(

new ScriptExecutor(web_contents(), &script_observers_));