Implement <webview> droplink event

content/browser/browser_plugin/browser_plugin_guest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/browser_plugin/browser_plugin_guest.h"
 
 #include <algorithm>
 
 #include "base/message_loop/message_loop.h"
 #include "base/pickle.h"
@@ skipping 427 matching lines @@
   //      {WebDragStatusOver, WebDragStatusDrop}. However, if a user drags
   //      a source quickly outside of <webview> bounds, then the
   //      BrowserPluginGuest never sees any of these drag status updates,
   //      there we just check whether we've seen any drag status update or
   //      not.
   if (last_drag_status_ != blink::WebDragStatusOver &&
       seen_embedder_drag_source_ended_at_ && seen_embedder_system_drag_ended_) {
     RenderViewHostImpl* guest_rvh = static_cast<RenderViewHostImpl*>(
         GetWebContents()->GetRenderViewHost());
     guest_rvh->DragSourceSystemDragEnded();
-
     last_drag_status_ = blink::WebDragStatusUnknown;
     seen_embedder_system_drag_ended_ = false;
     seen_embedder_drag_source_ended_at_ = false;
+    dragged_url_ = GURL();
   }
 }
 
 void BrowserPluginGuest::EmbedderSystemDragEnded() {
   seen_embedder_system_drag_ended_ = true;
   EndSystemDragIfApplicable();
 }
 
 void BrowserPluginGuest::SendQueuedMessages() {
   if (!attached())
@@ skipping 205 matching lines @@
 
   delegate_->DidDetach();
 }
 
 void BrowserPluginGuest::OnDragStatusUpdate(int browser_plugin_instance_id,
                                             blink::WebDragStatus drag_status,
                                             const DropData& drop_data,
                                             blink::WebDragOperationsMask mask,
                                             const gfx::Point& location) {
   RenderViewHost* host = GetWebContents()->GetRenderViewHost();
+  auto embedder = owner_web_contents_->GetBrowserPluginEmbedder();
   switch (drag_status) {
     case blink::WebDragStatusEnter:
-      owner_web_contents_->GetBrowserPluginEmbedder()->DragEnteredGuest(
-          this);
+      // Only track the URL being dragged over the guest if the link isn't
+      // coming from the guest.
+      if (!embedder->DragEnteredGuest(this))
+        dragged_url_ = drop_data.url;

[lazyboy, 2015/02/23 17:11:10]

Just double checking, if the drop data doesn't have a url then it's an
empty GURL, right?

[Fady Samuel, 2015/02/23 19:57:07]

Yup, the GURL is not valid, and spec() is empty string.

       host->DragTargetDragEnter(drop_data, location, location, mask, 0);
       break;
     case blink::WebDragStatusOver:
       host->DragTargetDragOver(location, location, mask, 0);
       break;
     case blink::WebDragStatusLeave:
       owner_web_contents_->GetBrowserPluginEmbedder()->DragLeftGuest(this);

[lazyboy, 2015/02/23 17:11:10]

Also, change this to use |embedder|

[Fady Samuel, 2015/02/23 19:57:07]

Done.

       host->DragTargetDragLeave();
       break;
     case blink::WebDragStatusDrop:
       host->DragTargetDrop(location, location, 0);
+      if (dragged_url_.is_valid()) {
+        delegate_->DidDropLink(dragged_url_);
+        dragged_url_ = GURL();
+      }
       break;
     case blink::WebDragStatusUnknown:
       NOTREACHED();
   }
   last_drag_status_ = drag_status;
   EndSystemDragIfApplicable();
 }
 
 void BrowserPluginGuest::OnExecuteEditCommand(int browser_plugin_instance_id,
                                               const std::string& name) {
@@ skipping 202 matching lines @@
 void BrowserPluginGuest::OnImeCompositionRangeChanged(
       const gfx::Range& range,
       const std::vector<gfx::Rect>& character_bounds) {
   static_cast<RenderWidgetHostViewBase*>(
       web_contents()->GetRenderWidgetHostView())->ImeCompositionRangeChanged(
           range, character_bounds);
 }
 #endif
 
 }  // namespace content