Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 945313003: emit premonomorphic ics for keyed loads/stores in optimized code (Closed)

Created:
5 years, 10 months ago by dcarney
Modified:
5 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

emit premonomorphic ics for keyed loads/stores in optimized code R=verwaest@chromium.org BUG= Committed: https://crrev.com/f1e2aa524cbba83add14d976bf6194d5f02df9e8 Cr-Commit-Position: refs/heads/master@{#26862}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -49 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M src/code-factory.h View 1 1 chunk +5 lines, -1 line 0 comments Download
M src/code-factory.cc View 1 2 chunks +19 lines, -8 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M src/hydrogen.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M src/hydrogen-instructions.h View 1 6 chunks +21 lines, -8 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M src/ic/ic.h View 1 2 chunks +6 lines, -1 line 0 comments Download
M src/ic/ic.cc View 1 2 chunks +36 lines, -5 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 2 chunks +6 lines, -3 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 1 2 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dcarney
ptal - will add arch files if okay
5 years, 10 months ago (2015-02-25 10:20:07 UTC) #2
Toon Verwaest
lgtm if performance is fine
5 years, 10 months ago (2015-02-25 13:58:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/945313003/60001
5 years, 10 months ago (2015-02-25 19:03:43 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-25 19:32:51 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 19:33:09 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/f1e2aa524cbba83add14d976bf6194d5f02df9e8
Cr-Commit-Position: refs/heads/master@{#26862}

Powered by Google App Engine
This is Rietveld 408576698