Web MIDI: chromium-side blink API update to support MIDIPortState

Web MIDI: chromium-side blink API update to support MIDIPortState

The latest editor's draft introduces MIDIPortState state attribute in
MIDIPort. To support the attribute, update the blink API to use enum
for representing MIDIPortState instead of bool isActive flag.

Spec: http://webaudio.github.io/web-midi-api/#idl-def-MIDIPort

This is the second step of three to update the MIDIAccessor blink API.

BUG=279097
TEST=content_unittests

Committed: https://crrev.com/5e0737b47025d908a698ed5eb2f1ade69bef81b7
Cr-Commit-Position: refs/heads/master@{#317572}

[Takashi Toyoshima, 2015-02-21 14:28:20]

toyoshim@chromium.org changed reviewers:
+ tkent@chromium.org, yhirano@chromium.org

[Takashi Toyoshima, 2015-02-21 14:30:51]

Hi guys, please take a look.

tkent: can you take a look especially on test_runner/* that maybe API owners
manage?
yhirano: can you take a look especially on media/midi_* ?

[tkent, 2015-02-22 23:39:22]

lgtm

https://codereview.chromium.org/945263002/diff/1/content/renderer/media/midi_...
File content/renderer/media/midi_message_filter_unittest.cc (right):

https://codereview.chromium.org/945263002/diff/1/content/renderer/media/midi_...
content/renderer/media/midi_message_filter_unittest.cc:13: typedef
blink::WebMIDIAccessorClient::MIDIPortState BlinkState;
We prefer |using| to |typedef| now.
https://chromium-cpp.appspot.com/

https://codereview.chromium.org/945263002/diff/1/content/renderer/media/midi_...
content/renderer/media/midi_message_filter_unittest.cc:30: 
nit: unnecessary blank lines.

[Takashi Toyoshima, 2015-02-23 05:32:22]

New patchsets have been uploaded after l-g-t-m from tkent@chromium.org

[Takashi Toyoshima, 2015-02-23 05:32:41]

https://codereview.chromium.org/945263002/diff/1/content/renderer/media/midi_...
File content/renderer/media/midi_message_filter_unittest.cc (right):

https://codereview.chromium.org/945263002/diff/1/content/renderer/media/midi_...
content/renderer/media/midi_message_filter_unittest.cc:13: typedef
blink::WebMIDIAccessorClient::MIDIPortState BlinkState;
On 2015/02/22 23:39:22, tkent wrote:
> We prefer |using| to |typedef| now.
> https://chromium-cpp.appspot.com/

Done.

https://codereview.chromium.org/945263002/diff/1/content/renderer/media/midi_...
content/renderer/media/midi_message_filter_unittest.cc:30: 
On 2015/02/22 23:39:22, tkent wrote:
> nit: unnecessary blank lines.

Done.

[yhirano, 2015-02-23 09:07:00]

lgtm

[Takashi Toyoshima, 2015-02-23 11:36:12]

The CQ bit was checked by toyoshim@chromium.org

[commit-bot: I haz the power, 2015-02-23 11:37:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/945263002/20001

[commit-bot: I haz the power, 2015-02-23 11:39:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-23 11:39:41]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[Takashi Toyoshima, 2015-02-23 12:08:25]

The CQ bit was checked by toyoshim@chromium.org

[commit-bot: I haz the power, 2015-02-23 12:09:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/945263002/20001

[commit-bot: I haz the power, 2015-02-23 12:27:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-23 12:27:58]

Patchset 2 (id:??) landed as
https://crrev.com/5e0737b47025d908a698ed5eb2f1ade69bef81b7
Cr-Commit-Position: refs/heads/master@{#317572}