Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 945243002: Version 4.2.77.1 (Closed)

Created:
5 years, 10 months ago by Michael Achenbach
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@4.2.77
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Version 4.2.77.1 Revert "Correctly propagate terminate exception in TryCall." This reverts commit a49b55b78844557b65a98e7a77dd26078157ed7f. R=jkummerow@chromium.org TBR=hablich@chromium.org, jkummerow@chromium.org, yangguo@chromium.org BUG=v8:3892 LOG=n Committed: https://chromium.googlesource.com/v8/v8/+/3dfd929ea07487f2295553df397720d8d75d227c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -37 lines) Patch
M src/execution.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-thread-termination.cc View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Achenbach
PTAL
5 years, 10 months ago (2015-02-21 13:22:02 UTC) #2
Jakob Kummerow
lgtm
5 years, 10 months ago (2015-02-21 13:23:03 UTC) #3
Michael Achenbach
Committed patchset #1 (id:1) manually as 3dfd929ea07487f2295553df397720d8d75d227c (presubmit successful).
5 years, 10 months ago (2015-02-21 13:26:07 UTC) #4
Michael Hablich
5 years, 10 months ago (2015-02-21 13:28:17 UTC) #5
Message was sent while issue was closed.
On 2015/02/21 13:26:07, Michael Achenbach wrote:
> Committed patchset #1 (id:1) manually as
> 3dfd929ea07487f2295553df397720d8d75d227c (presubmit successful).

lgtm

Powered by Google App Engine
This is Rietveld 408576698