Issue 945223002: Fix painting of position:absolute inside display: paragraphs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 945223002: Fix painting of position:absolute inside display: paragraphs. (Closed)

Created:
5 years, 10 months ago by ojan

Modified:
5 years, 10 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Fix painting of position:absolute inside display: paragraphs. We only need to walk the immediate children of the paragraph. The other inline children of the paragraph will get paint called on them and they will then appropriately add the self painting layers to the array inside their paint calls. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d2d61e7d142a6de3b2160422b74a158dfd9881a6

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -1 line)			Patch
	M	sky/engine/core/rendering/RenderParagraph.cpp	View		1 chunk	+11 lines, -0 lines	0 comments	Download
	M	sky/tests/layout/position-absolute-pixels-expected.sky	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (1 generated)

ojan

5 years, 10 months ago (2015-02-21 04:25:01 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
d2d61e7d142a6de3b2160422b74a158dfd9881a6 (presubmit successful).