Issue 945143003: Added an ApplicationConnection for the OnEmbed() SPs to Sky embedder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 945143003: Added an ApplicationConnection for the OnEmbed() SPs to Sky embedder (Closed)

Created:
5 years, 10 months ago by hansmuller

Modified:
5 years, 10 months ago

Reviewers:
zra, hansmuller1, abarth-chromium

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Added an ApplicationConnection for the OnEmbed() SPs to Sky embedder I also made the singleton embedder's fields static, so that they're lazily computed. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/17f78dd9e901649e8d9ddc96d970f2ac90cd99bc

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	sky/framework/embedder.dart	View		1 chunk	+7 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

hansmuller

5 years, 10 months ago (2015-02-23 15:28:53 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
17f78dd9e901649e8d9ddc96d970f2ac90cd99bc (presubmit successful).