Issue 945093002: jstemplate: add typechecking changes to please the compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 945093002: jstemplate: add typechecking changes to please the compiler. (Closed)

Created:
5 years, 10 months ago by Dan Beam

Modified:
5 years, 10 months ago

Reviewers:
Tyler Breisacher (Chromium)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

jstemplate: add typechecking changes to please the compiler. R=tbreisacher@chromium.org BUG=393873 Committed: https://crrev.com/a43a4b01d4c7bcfe5bf577d29ca35e58bb0a6360 Cr-Commit-Position: refs/heads/master@{#317443}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -5 lines)			Patch
M	third_party/jstemplate/README.chromium	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	third_party/jstemplate/jsevalcontext.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/jstemplate/jstemplate.js	View	3 chunks	+2 lines, -4 lines	0 comments	Download

Total messages: 8 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/945093002/20001

5 years, 10 months ago (2015-02-20 23:07:51 UTC) #6

commit-bot: I haz the power

5 years, 10 months ago (2015-02-20 23:45:45 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/a43a4b01d4c7bcfe5bf577d29ca35e58bb0a6360
Cr-Commit-Position: refs/heads/master@{#317443}