Issue 945083002: Fix display of fonts in SkyShell

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 945083002: Fix display of fonts in SkyShell (Closed)

Created:
5 years, 10 months ago by eseidel

Modified:
5 years, 10 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:abarth/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix display of fonts in SkyShell R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/29e47fdf3a07ed9c01676170d5efd7ef47514525

Patch Set 2 : nit fixed #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -0 lines)			Patch
	M	sky/shell/ui/engine.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	sky/shell/ui/engine.cc	View	1	4 chunks	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

https://codereview.chromium.org/945083002/diff/1/sky/shell/ui/engine.cc File sky/shell/ui/engine.cc (right): https://codereview.chromium.org/945083002/diff/1/sky/shell/ui/engine.cc#newcode22 sky/shell/ui/engine.cc:22: void ConfigureSettings(blink::WebSettings* settings) { Can you wrap this in ...

5 years, 10 months ago (2015-02-20 22:54:11 UTC) #1

eseidel

5 years, 10 months ago (2015-02-20 22:57:07 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
29e47fdf3a07ed9c01676170d5efd7ef47514525 (presubmit successful).

Expand Messages | Collapse Messages

Issue 945083002: Fix display of fonts in SkyShell (Closed)

Description

Patch Set 1 #

Patch Set 2 : nit fixed #

Messages