Restore L3 support on CrOS when the media permission is denied.

Restore L3 support on CrOS when the media permission is denied.

BUG=446263, 457482
Committed: https://crrev.com/cd52b1d018b5464584771f756d8f8ec37302421d
Cr-Commit-Position: refs/heads/master@{#317483}

[sandersd (OOO until July 31), 2015-02-20 22:54:13]

sandersd@chromium.org changed reviewers:
+ sandersd@chromium.org

[sandersd (OOO until July 31), 2015-02-20 22:54:13]

Seems fine to me, with the caveat that I don't think it does what you think it
does exactly.

I do prefer the simplicity of my version. Picking one over the other should be
decided on whether we want distinctiveIdentifer to be "not-allowed" (this CL) or
"required" (my CL) in this case.

lgtm.

https://codereview.chromium.org/945063002/diff/1/chrome/renderer/media/chrome...
File chrome/renderer/media/chrome_key_systems.cc (right):

https://codereview.chromium.org/945063002/diff/1/chrome/renderer/media/chrome...
chrome/renderer/media/chrome_key_systems.cc:201:
media::EME_FEATURE_ALWAYS_ENABLED,  // Persistent state.
I'm guessing that clang-format removed all the comment alignment spaces?

[ddorwin, 2015-02-20 23:10:41]

New patchsets have been uploaded after l-g-t-m from sandersd@chromium.org

[sandersd (OOO until July 31), 2015-02-20 23:17:59]

Temporary nolgtm.

This hits a DCHECK() in webencryptedmediaclient_impl.cc if permission is not
granted.

[ddorwin, 2015-02-20 23:40:28]

I fixed the DCHECK

https://codereview.chromium.org/945063002/diff/1/chrome/renderer/media/chrome...
File chrome/renderer/media/chrome_key_systems.cc (right):

https://codereview.chromium.org/945063002/diff/1/chrome/renderer/media/chrome...
chrome/renderer/media/chrome_key_systems.cc:201:
media::EME_FEATURE_ALWAYS_ENABLED,  // Persistent state.
On 2015/02/20 22:54:13, sandersd wrote:
> I'm guessing that clang-format removed all the comment alignment spaces?

Yes. Interestingly, it seems capable of preserving them when lines are adjacent.

[sandersd (OOO until July 31), 2015-02-20 23:50:21]

So many hacks :-(


lgtm.

[ddorwin, 2015-02-21 00:20:45]

New patchsets have been uploaded after l-g-t-m from sandersd@chromium.org

[ddorwin, 2015-02-21 00:21:06]

The CQ bit was checked by ddorwin@chromium.org

[commit-bot: I haz the power, 2015-02-21 00:21:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/945063002/60001

[ddorwin, 2015-02-21 00:37:26]

The CQ bit was checked by ddorwin@chromium.org

[ddorwin, 2015-02-21 00:38:38]

The CQ bit was unchecked by ddorwin@chromium.org

[ddorwin, 2015-02-21 00:39:16]

The CQ bit was checked by ddorwin@chromium.org

[commit-bot: I haz the power, 2015-02-21 00:40:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/945063002/80001

[commit-bot: I haz the power, 2015-02-21 01:46:23]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-02-21 01:47:09]

Patchset 5 (id:??) landed as
https://crrev.com/cd52b1d018b5464584771f756d8f8ec37302421d
Cr-Commit-Position: refs/heads/master@{#317483}