Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: remoting/webapp/js_proto/qunit_proto.js

Issue 945033002: Updated XHR API so call sites are more descriptive. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@xhr-test
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/webapp/crd/js/xhr.js ('k') | remoting/webapp/unittests/dns_blackhole_checker_unittest.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/js_proto/qunit_proto.js
diff --git a/remoting/webapp/js_proto/qunit_proto.js b/remoting/webapp/js_proto/qunit_proto.js
index f826af8c9b09d141a722fb7a887a352453fd4023..41ff67c34e31161b0369f25e87f02df2172ff3c2 100644
--- a/remoting/webapp/js_proto/qunit_proto.js
+++ b/remoting/webapp/js_proto/qunit_proto.js
@@ -26,6 +26,7 @@ QUnit.Clock.prototype.tick = function(ticks) {};
/**
* @param {string} desc
* @param {Function} f
+ * @deprecated
*/
QUnit.asyncTest = function(desc, f) {};
@@ -57,9 +58,9 @@ QUnit.module = function(desc, dict) {};
/**
* @param {*} a
* @param {*} b
- * @param {string} desc
+ * @param {string=} opt_desc
*/
-QUnit.notEqual = function(a, b, desc) {};
+QUnit.notEqual = function(a, b, opt_desc) {};
/**
* @param {boolean} cond
@@ -72,14 +73,35 @@ QUnit.start = function() {};
/**
* @param {string} desc
- * @param {Function} f
+ * @param {function(!QUnit.Assert)} f
*/
QUnit.test = function(desc, f) {};
/** @param {Function} f */
QUnit.testStart = function(f) {};
+/**
+ * @constructor
+ */
+QUnit.Assert = function() {};
+
+/**
+ * @return {function():void}
+ */
+QUnit.Assert.prototype.async = function() {};
+
+// TODO(jrw): Make these the primary definitions.
+QUnit.Assert.prototype.deepEqual = QUnit.deepEqual;
+QUnit.Assert.prototype.equal = QUnit.equal;
+QUnit.Assert.prototype.notEqual = QUnit.notEqual;
+QUnit.Assert.prototype.ok = QUnit.ok;
+
+/**
+ * @const {!QUnit.Assert}
+ */
+QUnit.assert;
+// TODO(jrw): Mark these as deprecated.
var deepEqual = QUnit.deepEqual;
var equal = QUnit.equal;
var expect = QUnit.expect;
« no previous file with comments | « remoting/webapp/crd/js/xhr.js ('k') | remoting/webapp/unittests/dns_blackhole_checker_unittest.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698