remoting/webapp/crd/js/dns_blackhole_checker.js - Issue 945033002: Updated XHR API so call sites are more descriptive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/webapp/crd/js/dns_blackhole_checker.js

Issue 945033002: Updated XHR API so call sites are more descriptive. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@xhr-test

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: remoting/webapp/crd/js/dns_blackhole_checker.js

diff --git a/remoting/webapp/crd/js/dns_blackhole_checker.js b/remoting/webapp/crd/js/dns_blackhole_checker.js

index 686d0684902e0727b7941ef1dfb7e68ece651041..6bc3a7d2abe3b9e506e273de982fa07c84a73b59 100644

--- a/remoting/webapp/crd/js/dns_blackhole_checker.js

+++ b/remoting/webapp/crd/js/dns_blackhole_checker.js

@@ -85,9 +85,11 @@ remoting.DnsBlackholeChecker.prototype.connect = function(server,

this.signalStrategy_.connect(server, username, authToken);

- this.xhr_ =

- remoting.xhr.get(remoting.DnsBlackholeChecker.URL_TO_REQUEST_,

- this.onHttpRequestDone_.bind(this));

+ this.xhr_ = remoting.xhr.start({

+ method: 'GET',

+ url: remoting.DnsBlackholeChecker.URL_TO_REQUEST_,

+ onDone: this.onHttpRequestDone_.bind(this)

+ });

};

remoting.DnsBlackholeChecker.prototype.getState = function() {

« no previous file with comments | « no previous file | remoting/webapp/crd/js/host_controller.js » ('j') | remoting/webapp/crd/js/host_controller.js » ('J')