Updated XHR API so call sites are more descriptive.

remoting/webapp/crd/js/oauth2_api_impl.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * OAuth2 API flow implementations.
  */
 
 'use strict';
@@ skipping 75 matching lines @@
         console.error('Invalid "token" response from server:', err);
         onError(remoting.Error.UNEXPECTED);
       }
     } else {
       console.error('Failed to refresh token. Status: ' + xhr.status +
                     ' response: ' + xhr.responseText);
       onError(remoting.Error.fromHttpStatus(xhr.status));
     }
   };
 
-  var parameters = {
-    'client_id': clientId,
-    'client_secret': clientSecret,
-    'refresh_token': refreshToken,
-    'grant_type': 'refresh_token'
-  };
-
-  remoting.xhr.post(this.getOAuth2TokenEndpoint_(), onResponse, parameters);
+  remoting.xhr.start({
+    method: 'POST',
+    url: this.getOAuth2TokenEndpoint_(),
+    onDone: onResponse,
+    formContent: {
+      'client_id': clientId,
+      'client_secret': clientSecret,
+      'refresh_token': refreshToken,
+      'grant_type': 'refresh_token'
+    }
+  });
 };
 
 /**
  * Asynchronously exchanges an authorization code for access and refresh tokens.
  *
  * @param {function(string, string, number): void} onDone Callback to
  *     invoke when the refresh token, access token and access token expiration
  *     time are successfully fetched.
  * @param {function(remoting.Error):void} onError Callback invoked if an
  *     error occurs.
@@ skipping 19 matching lines @@
         console.error('Invalid "token" response from server:', err);
         onError(remoting.Error.UNEXPECTED);
       }
     } else {
       console.error('Failed to exchange code for token. Status: ' + xhr.status +
                     ' response: ' + xhr.responseText);
       onError(remoting.Error.fromHttpStatus(xhr.status));
     }
   };
 
-  var parameters = {
-    'client_id': clientId,
-    'client_secret': clientSecret,
-    'redirect_uri': redirectUri,
-    'code': code,
-    'grant_type': 'authorization_code'
-  };
-  remoting.xhr.post(this.getOAuth2TokenEndpoint_(), onResponse, parameters);
+  remoting.xhr.start({
+    method: 'POST',
+    url: this.getOAuth2TokenEndpoint_(),
+    onDone: onResponse,
+    formContent: {
+      'client_id': clientId,
+      'client_secret': clientSecret,
+      'redirect_uri': redirectUri,
+      'code': code,
+      'grant_type': 'authorization_code'
+    }
+  });
 };
 
 /**
  * Get the user's email address.
  *
  * @param {function(string):void} onDone Callback invoked when the email
  *     address is available.
  * @param {function(remoting.Error):void} onError Callback invoked if an
  *     error occurs.
  * @param {string} token Access token.
  * @return {void} Nothing.
  */
 remoting.OAuth2ApiImpl.prototype.getEmail = function(onDone, onError, token) {
   /** @param {XMLHttpRequest} xhr */
   var onResponse = function(xhr) {
     if (xhr.status == 200) {
       try {
         var result = JSON.parse(xhr.responseText);
         onDone(result['email']);
       } catch (/** @type {Error} */ err) {
         console.error('Invalid "userinfo" response from server:', err);
         onError(remoting.Error.UNEXPECTED);
       }
     } else {
       console.error('Failed to get email. Status: ' + xhr.status +
                     ' response: ' + xhr.responseText);
       onError(remoting.Error.fromHttpStatus(xhr.status));
     }
   };
-  var headers = { 'Authorization': 'OAuth ' + token };
-  remoting.xhr.get(this.getOAuth2ApiUserInfoEndpoint_(),
-                   onResponse, '', headers);
+  remoting.xhr.start({
+    method: 'GET',
+    url: this.getOAuth2ApiUserInfoEndpoint_(),
+    onDone: onResponse,
+    oauthToken: token
+  });
 };
 
 /**
  * Get the user's email address and full name.
  *
  * @param {function(string, string):void} onDone Callback invoked when the email
  *     address and full name are available.
  * @param {function(remoting.Error):void} onError Callback invoked if an
  *     error occurs.
  * @param {string} token Access token.
@@ skipping 10 matching lines @@
       } catch (/** @type {Error} */ err) {
         console.error('Invalid "userinfo" response from server:', err);
         onError(remoting.Error.UNEXPECTED);
       }
     } else {
       console.error('Failed to get user info. Status: ' + xhr.status +
                     ' response: ' + xhr.responseText);
       onError(remoting.Error.fromHttpStatus(xhr.status));
     }
   };
-  var headers = { 'Authorization': 'OAuth ' + token };
-  remoting.xhr.get(this.getOAuth2ApiUserInfoEndpoint_(),
-                   onResponse, '', headers);
+  remoting.xhr.start({
+    method: 'GET',
+    url: this.getOAuth2ApiUserInfoEndpoint_(),
+    onDone: onResponse,
+    oauthToken: token
+  });
 };
 
 /** @type {remoting.OAuth2Api} */
 remoting.oauth2Api = new remoting.OAuth2ApiImpl();