Updated XHR API so call sites are more descriptive.

remoting/webapp/crd/js/host_controller.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /** @suppress {duplicate} */
 var remoting = remoting || {};
 
 /** @constructor */
@@ skipping 255 matching lines @@
 
   /**
    * @param {string} hostName
    * @param {string} privateKey
    * @param {string} publicKey
    * @param {?string} hostClientId
    * @param {string} oauthToken
    */
   function doRegisterHost(
       hostName, privateKey, publicKey, hostClientId, oauthToken) {
-    var headers = {
-      'Authorization': 'OAuth ' + oauthToken,
-      'Content-type' : 'application/json; charset=UTF-8'
-    };
-
     var newHostDetails = { data: {
        hostId: newHostId,
        hostName: hostName,
        publicKey: publicKey
     } };
 
     var registerHostUrl =
         remoting.settings.DIRECTORY_API_BASE_URL + '/@me/hosts';
 
-    if (hostClientId) {

[Jamie, 2015/02/21 01:35:48]

You've deleted this conditional. Was that intentional?

[John Williams, 2015/02/23 23:00:55]

Yes. The new version automagically omits URL parameters and headers whose value
is null.  I suppose line 289 in the new code should say "hostClientId || null"
to ensure the semantics haven't changed, but the type annotations led me to
believe hostClientId will always be truthy or null.

Omitting null fields feels somewhat magical to me, but it's a pattern I've used
a lot in the past, and I've always found the result easier to read than having
conditional logic at the call site.

-      registerHostUrl += '?' + remoting.xhr.urlencodeParamHash(
-          { hostClientId: hostClientId });
-    }
-
-    remoting.xhr.post(
-        registerHostUrl,
-        onRegistered.bind(null, hostName, publicKey, privateKey),
-        JSON.stringify(newHostDetails),
-        headers);
+    remoting.xhr.start({
+      method: 'POST',
+      url: remoting.settings.DIRECTORY_API_BASE_URL + '/@me/hosts',
+      urlParams: {
+        hostClientId: hostClientId
+      },
+      onDone: onRegistered.bind(null, hostName, publicKey, privateKey),
+      jsonContent: newHostDetails,
+      oauthToken: oauthToken
+    });
   }
 
   /**
    * @param {string} hostName
    * @param {string} privateKey
    * @param {string} publicKey
    * @param {string} hostClientId
    */
   function onHostClientId(
       hostName, privateKey, publicKey, hostClientId) {
@@ skipping 260 matching lines @@
   function connectSignalingWithTokenAndEmail(token, email) {
     signalStrategy.connect(
         remoting.settings.XMPP_SERVER_FOR_CLIENT, email, token);
   }
 
   remoting.identity.callWithToken(connectSignalingWithToken, onError);
 };
 
 /** @type {remoting.HostController} */
 remoting.hostController = null;