Issue 94503003: Split ResourceDispatcherHostImpl::BeginRequest

Issue 94503003: Split ResourceDispatcherHostImpl::BeginRequest (Closed)

Created:
7 years ago by tyoshino (SeeGerritForStatus)

Modified:
7 years ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Split ResourceDispatcherHostImpl::BeginRequest This method is very long. Factor out code building a resource handler into a separate method to improve readability. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238346

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Patch Set 3 : addressed #2 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -1 line)			Patch
	M	content/browser/loader/resource_dispatcher_host_impl.h	View	1 2	1 chunk	+12 lines, -0 lines	0 comments	Download
	M	content/browser/loader/resource_dispatcher_host_impl.cc	View		2 chunks	+18 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jam

lgtm https://codereview.chromium.org/94503003/diff/1/content/browser/loader/resource_dispatcher_host_impl.h File content/browser/loader/resource_dispatcher_host_impl.h (right): https://codereview.chromium.org/94503003/diff/1/content/browser/loader/resource_dispatcher_host_impl.h#newcode376 content/browser/loader/resource_dispatcher_host_impl.h:376: scoped_ptr<ResourceHandler> CreateResourceHandler( nit: add comment

7 years ago (2013-12-02 17:23:55 UTC) #2

tyoshino (SeeGerritForStatus)

https://codereview.chromium.org/94503003/diff/1/content/browser/loader/resource_dispatcher_host_impl.h File content/browser/loader/resource_dispatcher_host_impl.h (right): https://codereview.chromium.org/94503003/diff/1/content/browser/loader/resource_dispatcher_host_impl.h#newcode376 content/browser/loader/resource_dispatcher_host_impl.h:376: scoped_ptr<ResourceHandler> CreateResourceHandler( On 2013/12/02 17:23:55, jam wrote: > nit: ...

7 years ago (2013-12-03 04:50:19 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/94503003/40001

7 years ago (2013-12-03 04:50:33 UTC) #4

Message was sent while issue was closed.

Change committed as 238346

Expand Messages | Collapse Messages