Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 944933004: Add suppressions for recently failing tests. (Closed)

Created:
5 years, 10 months ago by Ken Russell (switch to Gerrit)
Modified:
5 years, 10 months ago
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Suppressions for bug 460580. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
Ken Russell (switch to Gerrit)
5 years, 10 months ago (2015-02-20 19:39:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/944933004/20001
5 years, 10 months ago (2015-02-20 19:42:19 UTC) #3
jbroman
On 2015/02/20 19:42:19, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
5 years, 10 months ago (2015-02-20 20:07:22 UTC) #4
Ken Russell (switch to Gerrit)
On 2015/02/20 20:07:22, jbroman wrote: > On 2015/02/20 19:42:19, I haz the power (commit-bot) wrote: ...
5 years, 10 months ago (2015-02-20 20:23:10 UTC) #5
Ken Russell (switch to Gerrit)
This is ridiculous -- these suppressions failed mac_blink_rel the first time around because of more ...
5 years, 10 months ago (2015-02-20 21:39:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/944933004/40001
5 years, 10 months ago (2015-02-20 21:42:24 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=190580
5 years, 10 months ago (2015-02-20 21:43:22 UTC) #10
jam
On 2015/02/20 21:39:44, Ken Russell wrote: > This is ridiculous -- these suppressions failed mac_blink_rel ...
5 years, 10 months ago (2015-02-20 21:45:24 UTC) #11
marja
What's up w/ fast/workers/worker-exception-during-navigation.html ? At some point I thought my CL https://codereview.chromium.org/936333005/ might affect ...
5 years, 10 months ago (2015-02-23 08:39:37 UTC) #12
Ken Russell (switch to Gerrit)
5 years, 10 months ago (2015-02-23 18:40:23 UTC) #13
Message was sent while issue was closed.
On 2015/02/23 08:39:37, marja wrote:
> What's up w/ fast/workers/worker-exception-during-navigation.html ? At some
> point I thought my CL https://codereview.chromium.org/936333005/ might affect
it
> since it showed red in my try jobs, but I tried it locally and it crashed both
> with and without my CL. (My CL turns ASSERTs to RELEASE_ASSERTs anyway, so, if
> the test hits those ASSERTs that should be clear from the error message, plus
> that should've failed before...)

Not sure -- please follow up on crbug.com/460356 .

Powered by Google App Engine
This is Rietveld 408576698