Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 944903002: Make sure exception handlers are deferred. (Closed)

Created:
5 years, 10 months ago by Michael Starzinger
Modified:
5 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make sure exception handlers are deferred. R=bmeurer@chromium.org TEST=unittests/SchedulerTest.CallException Committed: https://crrev.com/b33f552f348f445848b3b5e95f42d2af0956638b Cr-Commit-Position: refs/heads/master@{#26816}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -2 lines) Patch
M src/compiler/scheduler.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M test/unittests/compiler/scheduler-unittest.cc View 2 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Michael Starzinger
5 years, 10 months ago (2015-02-20 14:48:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/944903002/1
5 years, 10 months ago (2015-02-20 16:21:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/944903002/1
5 years, 10 months ago (2015-02-20 16:21:26 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 10 months ago (2015-02-20 16:21:27 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 10 months ago (2015-02-20 16:21:28 UTC) #8
Michael Starzinger
PTAL. Changed reviewer to Benedikt since Ben is OOO.
5 years, 10 months ago (2015-02-24 09:50:02 UTC) #10
Benedikt Meurer
LGTM.
5 years, 10 months ago (2015-02-24 11:40:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/944903002/1
5 years, 10 months ago (2015-02-24 11:43:40 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-24 11:44:50 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 11:45:04 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b33f552f348f445848b3b5e95f42d2af0956638b
Cr-Commit-Position: refs/heads/master@{#26816}

Powered by Google App Engine
This is Rietveld 408576698