Issue 9449: mcHammer merge IconMac.cpp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9449: mcHammer merge IconMac.cpp (Closed)

Created:
12 years, 1 month ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs), darin (slow to review)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/branches/chrome_webkit_merge_branch/src/

Visibility:
Public.

Description

IconMac changes to conform to upstream interface definition change: rename newIconForFile to createIconForFile, and add createIconForFiles. These are still just stubs. Mac equivalent of r4633 and r4708 in IconWin.cpp. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=4881

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	webkit/port/platform/graphics/mac/IconMac.cpp	View		1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM, thanks!

Expand Messages | Collapse Messages