Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 944843002: Prepare for new variable to build Mojo network service from source (Closed)

Created:
5 years, 10 months ago by blundell
Modified:
5 years, 10 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prepare for new variable to build Mojo network service from source https://codereview.chromium.org/939753003/ will change the name of the variable used to build the network service from source. This CL prepares for that change. Committed: https://crrev.com/4ebbe7388d44ffd8d235b85efddfa13b09bd50ed Cr-Commit-Position: refs/heads/master@{#317386}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M build/module_args/mojo.gni View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
blundell
5 years, 10 months ago (2015-02-20 13:01:50 UTC) #2
scottmg
lgtm
5 years, 10 months ago (2015-02-20 16:10:05 UTC) #3
ShahrulSafwan90
5 years, 10 months ago (2015-02-20 16:30:03 UTC) #5
ShahrulSafwan90
On 2015/02/20 16:30:03, ShahrulSafwan90 wrote:
5 years, 10 months ago (2015-02-20 16:30:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/944843002/1
5 years, 10 months ago (2015-02-20 19:15:13 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 20:24:33 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 20:25:11 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ebbe7388d44ffd8d235b85efddfa13b09bd50ed
Cr-Commit-Position: refs/heads/master@{#317386}

Powered by Google App Engine
This is Rietveld 408576698