Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: src/lazy/SkDiscardablePixelRef.h

Issue 944823004: SkDiscardablePixelRef should favor not decoding to YUV if they already decoded to RGB. (Closed) Base URL: https://chromium.googlesource.com/skia.git@master
Patch Set: Fixed nits. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2013 Google Inc. 2 * Copyright 2013 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #ifndef SkDiscardablePixelRef_DEFINED 8 #ifndef SkDiscardablePixelRef_DEFINED
9 #define SkDiscardablePixelRef_DEFINED 9 #define SkDiscardablePixelRef_DEFINED
10 10
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 45
46 /* Takes ownership of SkImageGenerator. */ 46 /* Takes ownership of SkImageGenerator. */
47 SkDiscardablePixelRef(const SkImageInfo&, SkImageGenerator*, 47 SkDiscardablePixelRef(const SkImageInfo&, SkImageGenerator*,
48 size_t rowBytes, 48 size_t rowBytes,
49 SkDiscardableMemory::Factory* factory); 49 SkDiscardableMemory::Factory* factory);
50 50
51 virtual bool onGetYUV8Planes(SkISize sizes[3], 51 virtual bool onGetYUV8Planes(SkISize sizes[3],
52 void* planes[3], 52 void* planes[3],
53 size_t rowBytes[3], 53 size_t rowBytes[3],
54 SkYUVColorSpace* colorSpace) SK_OVERRIDE { 54 SkYUVColorSpace* colorSpace) SK_OVERRIDE {
55 // If the image was already decoded with lockPixels(), favor not
56 // re-decoding to YUV8 planes.
57 if (fDiscardableMemory) {
58 return false;
59 }
55 return fGenerator->getYUV8Planes(sizes, planes, rowBytes, colorSpace); 60 return fGenerator->getYUV8Planes(sizes, planes, rowBytes, colorSpace);
56 } 61 }
57 62
58 friend bool SkInstallDiscardablePixelRef(SkImageGenerator*, SkBitmap*, 63 friend bool SkInstallDiscardablePixelRef(SkImageGenerator*, SkBitmap*,
59 SkDiscardableMemory::Factory*); 64 SkDiscardableMemory::Factory*);
60 65
61 typedef SkPixelRef INHERITED; 66 typedef SkPixelRef INHERITED;
62 }; 67 };
63 68
64 #endif // SkDiscardablePixelRef_DEFINED 69 #endif // SkDiscardablePixelRef_DEFINED
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698