Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 944803002: [turbofan] Finally get rid of the generic algorithm. (Closed)

Created:
5 years, 10 months ago by Benedikt Meurer
Modified:
5 years, 10 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Finally get rid of the generic algorithm. R=svenpanne@chromium.org Committed: https://crrev.com/5bbe693e4817011b6a496c638c9f09026fd3dac9 Cr-Commit-Position: refs/heads/master@{#26760} Committed: https://crrev.com/9e6181d5c32912aa46341456b7eb133e2686a7b6 Cr-Commit-Position: refs/heads/master@{#26767}

Patch Set 1 #

Patch Set 2 : Remove static initializer. #

Patch Set 3 : REBASE. FIX. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -281 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D src/compiler/generic-algorithm.h View 1 chunk +0 lines, -120 lines 0 comments Download
D src/compiler/graph-inl.h View 1 chunk +0 lines, -25 lines 0 comments Download
M src/compiler/js-inlining.h View 2 chunks +5 lines, -7 lines 0 comments Download
M src/compiler/js-inlining.cc View 1 2 7 chunks +67 lines, -81 lines 0 comments Download
M test/cctest/compiler/test-control-reducer.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/test-machine-operator-reducer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/test-node-algorithm.cc View 2 chunks +0 lines, -40 lines 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Benedikt Meurer
PTAL
5 years, 10 months ago (2015-02-20 08:09:45 UTC) #2
Sven Panne
lgtm
5 years, 10 months ago (2015-02-20 08:13:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/944803002/1
5 years, 10 months ago (2015-02-20 08:13:59 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/3143)
5 years, 10 months ago (2015-02-20 08:29:30 UTC) #7
Benedikt Meurer
Committed patchset #2 (id:20001) manually as 5bbe693e4817011b6a496c638c9f09026fd3dac9 (presubmit successful).
5 years, 10 months ago (2015-02-20 08:43:00 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/5bbe693e4817011b6a496c638c9f09026fd3dac9 Cr-Commit-Position: refs/heads/master@{#26760}
5 years, 10 months ago (2015-02-20 08:43:03 UTC) #10
Michael Achenbach
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/941963003/ by machenbach@chromium.org. ...
5 years, 10 months ago (2015-02-20 09:14:03 UTC) #11
Benedikt Meurer
Committed patchset #3 (id:40001) manually as 9e6181d5c32912aa46341456b7eb133e2686a7b6 (tree was closed).
5 years, 10 months ago (2015-02-20 10:12:08 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 10:12:15 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9e6181d5c32912aa46341456b7eb133e2686a7b6
Cr-Commit-Position: refs/heads/master@{#26767}

Powered by Google App Engine
This is Rietveld 408576698