Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 944763004: Revert of bpf_dsl: switch PolicyCompiler from seccomp-bpf/die.h to base/logging.h (Closed)

Created:
5 years, 10 months ago by mdempsky
Modified:
5 years, 10 months ago
CC:
chromium-reviews, rickyz+watch_chromium.org, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of bpf_dsl: switch PolicyCompiler from seccomp-bpf/die.h to base/logging.h (patchset #1 id:1 of https://codereview.chromium.org/945743002/) Reason for revert: To allow https://codereview.chromium.org/937303005/ to submit. Original issue's description: > bpf_dsl: switch PolicyCompiler from seccomp-bpf/die.h to base/logging.h > > PolicyCompiler runs in a normal process context, so it doesn't require > the extra low-levelness of SANDBOX_DIE. > > BUG=449357 > > Committed: https://crrev.com/deed70455d69ca62e4a5bfd2123a9376c5197797 > Cr-Commit-Position: refs/heads/master@{#317265} TBR=jln@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=449357 Committed: https://crrev.com/cc5607e5462682d482446fde3cf21f58dfcad60f Cr-Commit-Position: refs/heads/master@{#317294}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -37 lines) Patch
M sandbox/linux/bpf_dsl/policy_compiler.cc View 5 chunks +48 lines, -32 lines 0 comments Download
M sandbox/linux/bpf_dsl/trap_registry.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mdempsky
Created Revert of bpf_dsl: switch PolicyCompiler from seccomp-bpf/die.h to base/logging.h
5 years, 10 months ago (2015-02-20 11:36:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/944763004/1
5 years, 10 months ago (2015-02-20 11:36:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 11:37:00 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cc5607e5462682d482446fde3cf21f58dfcad60f Cr-Commit-Position: refs/heads/master@{#317294}
5 years, 10 months ago (2015-02-20 11:37:24 UTC) #4
kaliamoorthi
5 years, 10 months ago (2015-02-20 12:17:31 UTC) #5
Message was sent while issue was closed.
On 2015/02/20 11:37:24, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/cc5607e5462682d482446fde3cf21f58dfcad60f
> Cr-Commit-Position: refs/heads/master@{#317294}

I am not sure if this revert is necessary. Revert of 939943002 seem to solve the
problem.

Powered by Google App Engine
This is Rietveld 408576698