ui/wm/core/focus_controller.h - Issue 944763002: Make Page Visibility API work when the browser window is visible or not

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/wm/core/focus_controller.h

Issue 944763002: Make Page Visibility API work when the browser window is visible or not Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove the VisibilityNotify event handler Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc ('K') | « ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc ('k') | ui/wm/core/focus_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/wm/core/focus_controller.h

diff --git a/ui/wm/core/focus_controller.h b/ui/wm/core/focus_controller.h

index 43d3c608b2138493f070bce4150b24a073edca58..a8ff75f2b7f25c9d8eb4dfe54aaa7fe4a611d3f4 100644

--- a/ui/wm/core/focus_controller.h

+++ b/ui/wm/core/focus_controller.h

@@ -70,7 +70,8 @@ class WM_EXPORT FocusController : public aura::client::ActivationClient,

void OnGestureEvent(ui::GestureEvent* event) override;

// Overridden from aura::WindowObserver:

- void OnWindowVisibilityChanged(aura::Window* window, bool visible) override;

+ void OnWindowVisibilityChanged(aura::Window* window, bool visible,

+ bool contentVisible) override;

Elliot Glaysher 2015/03/03 00:33:52 nit: camel case doesn't match the cc file, use uni

void OnWindowDestroying(aura::Window* window) override;

void OnWindowHierarchyChanging(const HierarchyChangeParams& params) override;

void OnWindowHierarchyChanged(const HierarchyChangeParams& params) override;