ui/keyboard/keyboard_controller_unittest.cc - Issue 944763002: Make Page Visibility API work when the browser window is visible or not

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/keyboard/keyboard_controller_unittest.cc

Issue 944763002: Make Page Visibility API work when the browser window is visible or not Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove the VisibilityNotify event handler Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_widget_host_view_aura.cc ('K') | « ui/aura/window_unittest.cc ('k') | ui/views/controls/native/native_view_host_aura_unittest.cc » ('j') | ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/keyboard/keyboard_controller_unittest.cc

diff --git a/ui/keyboard/keyboard_controller_unittest.cc b/ui/keyboard/keyboard_controller_unittest.cc

index fd5b0878434191e3fc1861abdc291463d6fc06c8..3597183911a709a59394fb6effd5a9e259757ee3 100644

--- a/ui/keyboard/keyboard_controller_unittest.cc

+++ b/ui/keyboard/keyboard_controller_unittest.cc

@@ -148,7 +148,8 @@ class KeyboardContainerObserver : public aura::WindowObserver {

~KeyboardContainerObserver() override { window_->RemoveObserver(this); }

private:

- void OnWindowVisibilityChanged(aura::Window* window, bool visible) override {

+ void OnWindowVisibilityChanged(aura::Window* window, bool visible,

+ bool content_visible) override {

if (!visible)

base::MessageLoop::current()->Quit();

}