ash/wm/immersive_fullscreen_controller.cc - Issue 944763002: Make Page Visibility API work when the browser window is visible or not

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/immersive_fullscreen_controller.cc

Issue 944763002: Make Page Visibility API work when the browser window is visible or not Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove the VisibilityNotify event handler Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/frame_host/render_widget_host_view_child_frame.h » ('j') | content/browser/renderer_host/render_widget_host_view_aura.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/wm/immersive_fullscreen_controller.cc

diff --git a/ash/wm/immersive_fullscreen_controller.cc b/ash/wm/immersive_fullscreen_controller.cc

index 75781d5577ab2c74bc0c5ec36f0ce55488db5f52..ec55104de88c70db0f23dfff0a67258c60a42bd6 100644

--- a/ash/wm/immersive_fullscreen_controller.cc

+++ b/ash/wm/immersive_fullscreen_controller.cc

@@ -143,7 +143,9 @@ class ImmersiveFullscreenController::BubbleManager

void UpdateRevealedLock();

// aura::WindowObserver overrides:

- void OnWindowVisibilityChanged(aura::Window* window, bool visible) override;

+ void OnWindowVisibilityChanged(aura::Window* window,

+ bool visible,

+ bool content_visible) override;

void OnWindowDestroying(aura::Window* window) override;

ImmersiveFullscreenController* controller_;

@@ -223,7 +225,8 @@ void ImmersiveFullscreenController::BubbleManager::UpdateRevealedLock() {

void ImmersiveFullscreenController::BubbleManager::OnWindowVisibilityChanged(

aura::Window*,

- bool visible) {

+ bool visible,

+ bool content_visible) {

UpdateRevealedLock();

}