src/typedarray.js - Issue 94473002: Ensure that length is Smi in TypedArrayFromArrayLike constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/typedarray.js

Issue 94473002: Ensure that length is Smi in TypedArrayFromArrayLike constructor. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/typedarray.js

diff --git a/src/typedarray.js b/src/typedarray.js

index fc3a608f46ff83afd30b4b1108ac1f24e2419602..e15c4c17b13c31423e23d047eb1684882da6e005 100644

--- a/src/typedarray.js

+++ b/src/typedarray.js

@@ -98,6 +98,9 @@ macro TYPED_ARRAY_CONSTRUCTOR(ARRAY_ID, NAME, ELEMENT_SIZE)

function NAMEConstructByArrayLike(obj, arrayLike) {

var length = arrayLike.length;

var l = ToPositiveInteger(length, "invalid_typed_array_length");

+ if (l > %MaxSmi()) {

+ throw MakeRangeError("invalid_typed_array_length");

+ }

if(!%TypedArrayInitializeFromArrayLike(obj, ARRAY_ID, arrayLike, l)) {

for (var i = 0; i < l; i++) {

// It is crucial that we let any execptions from arrayLike[i]

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-324028.js » ('j') | no next file with comments »