Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 944683003: Files.app: Use <button> instead of <paper-button> to make ENTER and SPACE effective on them. (Closed)

Created:
5 years, 10 months ago by fukino
Modified:
5 years, 10 months ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Use <button> instead of <paper-button> to make ENTER and SPACE effective on them. <paper-button> does not handle ENTER and SPACE by default, so this CL change the buttons to <button>s. <button>s on the footer already have style similar to paper-button, so the visual style for each button is not changed. BUG=461758 TEST=manually check the response for ENTER/SPACE Committed: https://crrev.com/aab6df45d814cd913a0401af812f8ac89d6017b4 Cr-Commit-Position: refs/heads/master@{#318036}

Patch Set 1 #

Patch Set 2 : Update the browser test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M ui/file_manager/file_manager/main.html View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/file_manager/integration_tests/file_manager/file_dialog.js View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
fukino
PTAL. Thanks!
5 years, 10 months ago (2015-02-25 11:13:34 UTC) #2
yawano
Could you check that the following selector is affected by this change or not? Thank ...
5 years, 10 months ago (2015-02-25 11:26:41 UTC) #3
fukino
On 2015/02/25 11:26:41, yawano wrote: > Could you check that the following selector is affected ...
5 years, 10 months ago (2015-02-25 11:44:40 UTC) #4
yawano
lgtm. Thank you!
5 years, 10 months ago (2015-02-25 12:08:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/944683003/20001
5 years, 10 months ago (2015-02-25 12:59:55 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-25 13:34:22 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 13:34:46 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aab6df45d814cd913a0401af812f8ac89d6017b4
Cr-Commit-Position: refs/heads/master@{#318036}

Powered by Google App Engine
This is Rietveld 408576698