Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 944633002: Add a "name" field to the wallet address proto. (Closed)

Created:
5 years, 10 months ago by brettw
Modified:
5 years, 10 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, albertb+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a "name" field to the wallet address proto. This was forgotten in the initial pass. R=estade@chromium.org Committed: https://crrev.com/1a0ad2ec395a54dab0c31d265e4db67f0b8b9eba Cr-Commit-Position: refs/heads/master@{#317182}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M sync/protocol/autofill_specifics.proto View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
brettw
5 years, 10 months ago (2015-02-19 23:06:42 UTC) #1
Evan Stade
https://codereview.chromium.org/944633002/diff/1/sync/protocol/autofill_specifics.proto File sync/protocol/autofill_specifics.proto (right): https://codereview.chromium.org/944633002/diff/1/sync/protocol/autofill_specifics.proto#newcode122 sync/protocol/autofill_specifics.proto:122: optional name = 12; nit: recipient_name to match upstream?
5 years, 10 months ago (2015-02-19 23:09:12 UTC) #2
brettw
Sure, done.
5 years, 10 months ago (2015-02-19 23:13:47 UTC) #3
Evan Stade
lgtm
5 years, 10 months ago (2015-02-19 23:14:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/944633002/20001
5 years, 10 months ago (2015-02-19 23:18:32 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-20 00:11:29 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 00:12:30 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1a0ad2ec395a54dab0c31d265e4db67f0b8b9eba
Cr-Commit-Position: refs/heads/master@{#317182}

Powered by Google App Engine
This is Rietveld 408576698