ChromeOS: Update browser option UI for automatic timezone detection.

chrome/browser/resources/options/browser_options.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.exportPath('options');
 
 /**
  * @typedef {{actionLinkText: (string|undefined),
  *            childUser: (boolean|undefined),
  *            hasError: (boolean|undefined),
@@ skipping 380 matching lines @@
 
         if ($('themes-native-button')) {
           $('themes-native-button').onclick = function(event) {
             chrome.send('themesSetNative');
           };
         }
       }
 
       // Date and time section (CrOS only).
       if (cr.isChromeOS) {
         if ($('set-time-button'))

[michaelpg, 2015/02/24 13:04:39]

by the way, this check is redundant now

[Alexander Alekseev, 2015/02/25 20:39:41]

Why? It seems I haven't changed its behavior.

[michaelpg, 2015/02/27 18:12:29]

True, I think the outer if statement had been added in the lady change. The
button appears if and only if we're on chrome os, so now that we're checking
cr.isChromeOs, the button will always exist.

           $('set-time-button').onclick = this.handleSetTime_.bind(this);
 
         // Timezone
         if (loadTimeData.getBoolean('enableTimeZoneTrackingOption')) {
           $('resolve-timezone-by-geolocation-selection').hidden = false;
           this.setSystemTimezoneManaged_(false);
+          $('timezone-value-select').disabled = loadTimeData.getBoolean(

[michaelpg, 2015/02/19 22:38:36]

Do we re-enable this dropdown if I uncheck the resolve-timezone-by-geolocation
input?

[Alexander Alekseev, 2015/02/19 22:41:55]

Yes. See setSystemTimezoneManaged() code.

[michaelpg, 2015/02/24 06:38:06]

Sorry, I'm confused. Assuming no enterprise policy, if
resolve-timezone-by-geolocation is initially checked, how does
$('timezone-value-select') get enabled if I uncheck
resolve-timezone-by-geolocation?

[Alexander Alekseev, 2015/02/24 12:18:30]

setSystemTimezoneManaged() creates onclick handler:

$('resolve-timezone-by-geolocation').onclick = function(event) {                

    $('timezone-value-select').disabled = event.currentTarget.checked;          

}; 

[michaelpg, 2015/02/24 13:04:39]

Ah, I see. It's kind of unintuitive that we rely on that function for this
functionality. I'd suggest moving that click handler logic to a separate
function which we can use both here and in setSystemTimezoneManaged_.

[Alexander Alekseev, 2015/02/25 20:39:41]

This would lead to duplicate call to this new function on initialization,
because enableTimeZoneTrackingOption actually means that system time zone is not
managed:

--- chrome/browser/ui/webui/options/browser_options_handler.cc ---

 678   values->SetBoolean("enableTimeZoneTrackingOption",
 679                      !have_disable_time_zone_tracking_option_switch &&
 680                          !chromeos::system::HasSystemTimezonePolicy());

------------------------------------------------------------------

+              'resolveTimezoneByGeolocationInitialValue');
         }
       }
 
       // Default browser section.
       if (!cr.isChromeOS) {
         if (!loadTimeData.getBoolean('showSetDefault')) {
           $('set-default-browser-section').hidden = true;
         }
         $('set-as-default-browser').onclick = function(event) {
           chrome.send('becomeDefaultBrowser');
@@ skipping 1672 matching lines @@
           $('profiles-supervised-dashboard-tip').hidden;
     },
 
     /**
      * Updates the date and time section with time sync information.
      * @param {boolean} canSetTime Whether the system time can be set.
      * @private
      */
     setCanSetTime_: function(canSetTime) {
       // If the time has been network-synced, it cannot be set manually.
-      $('time-synced-explanation').hidden = canSetTime;
       $('set-time').hidden = !canSetTime;
     },
 
     /**
      * Handle the 'set date and time' button click.
      * @private
      */
     handleSetTime_: function() {
       chrome.send('showSetTime');
     },
@@ skipping 57 matching lines @@
     'setFontSize',
     'setHotwordRetrainLinkVisible',
     'setNativeThemeButtonEnabled',
     'setNetworkPredictionValue',
     'setHighContrastCheckboxState',
     'setAllHotwordSectionsVisible',
     'setMetricsReportingCheckboxState',
     'setMetricsReportingSettingVisibility',
     'setProfilesInfo',
     'setSpokenFeedbackCheckboxState',
+    'setSystemTimezoneManaged',

[michaelpg, 2015/02/24 13:04:39]

so this is an existing bug, since the function is already being called by the
C++?

[Alexander Alekseev, 2015/02/25 20:39:41]

Yes.

     'setThemesResetButtonEnabled',
     'setVirtualKeyboardCheckboxState',
     'setupPageZoomSelector',
     'setupProxySettingsButton',
     'setAudioHistorySectionVisible',
     'showBluetoothSettings',
     'showCreateProfileError',
     'showCreateProfileSuccess',
     'showCreateProfileWarning',
     'showHotwordAlwaysOnSection',
@@ skipping 59 matching lines @@
       }
       button.textContent = loadTimeData.getString(strId);
     };
   }
 
   // Export
   return {
     BrowserOptions: BrowserOptions
   };
 });