Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2752)

Unified Diff: chrome/browser/profiles/profile_metrics.h

Issue 944563002: Fix fast user switcher appearance when empty. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_metrics.h
diff --git a/chrome/browser/profiles/profile_metrics.h b/chrome/browser/profiles/profile_metrics.h
index 8feb60fe2f48c3a876b2d7e0db070a4fc38ce104..fde013aa70e20081a8669036aa88ce8520f4080b 100644
--- a/chrome/browser/profiles/profile_metrics.h
+++ b/chrome/browser/profiles/profile_metrics.h
@@ -55,15 +55,26 @@ class ProfileMetrics {
// Enum for counting the ways user profiles and menus were opened.
enum ProfileOpen {
- NTP_AVATAR_BUBBLE = 0, // User opens avatar menu from NTP
- ICON_AVATAR_BUBBLE, // User opens the avatar menu from button
- SWITCH_PROFILE_ICON, // User switches profiles from icon menu
- SWITCH_PROFILE_MENU, // User switches profiles from menu bar
- SWITCH_PROFILE_DOCK, // User switches profiles from dock (Mac-only)
- OPEN_USER_MANAGER, // User opens the User Manager
- SWITCH_PROFILE_MANAGER, // User switches profiles from the User Manager
- SWITCH_PROFILE_UNLOCK, // User switches to lockd profile via User Manager
- SWITCH_PROFILE_GUEST, // User switches to guest profile
+ // User opens avatar menu from NTP.
+ NTP_AVATAR_BUBBLE = 0,
+ // User opens the avatar menu from button.
+ ICON_AVATAR_BUBBLE,
+ // User switches profiles from icon menu.
+ SWITCH_PROFILE_ICON,
+ // User switches profiles from menu bar.
+ SWITCH_PROFILE_MENU,
+ // User switches profiles from dock (Mac-only).
+ SWITCH_PROFILE_DOCK,
+ // User opens the User Manager.
+ OPEN_USER_MANAGER,
+ // User switches profiles from the User Manager.
+ SWITCH_PROFILE_MANAGER,
+ // User switches to locked profile via User Manager.
+ SWITCH_PROFILE_UNLOCK,
+ // User switches to guest profile.
+ SWITCH_PROFILE_GUEST,
+ // User switches profiles from the Avatar Menu fast user switcher.
Mike Lerman 2015/02/20 14:40:57 s/Avatar Menu/User Menu
anthonyvd 2015/02/20 15:01:31 Done.
+ SWITCH_PROFILE_FAST_SWITCHER,
Alexei Svitkine (slow) 2015/02/19 22:24:28 Please update histograms.xml' definition of this e
anthonyvd 2015/02/20 15:01:31 Done.
NUM_PROFILE_OPEN_METRICS
};

Powered by Google App Engine
This is Rietveld 408576698