Context menu item to view original image when Data Saver is being used.

chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc

Index: chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
diff --git a/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc b/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
index 26a7ce8fe9b1abca57df2968a54ffc82fa14dffe..88237f1cb88b5cfd2ce8c528715fae923c2f5757 100644
--- a/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
+++ b/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
@@ -4,6 +4,7 @@
 
 #include <string>
 
+#include "base/command_line.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
@@ -20,6 +21,7 @@
 #include "chrome/common/render_messages.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/ui_test_utils.h"
+#include "components/data_reduction_proxy/core/common/data_reduction_proxy_switches.h"
 #include "components/search_engines/template_url_data.h"
 #include "components/search_engines/template_url_service.h"
 #include "content/public/browser/browser_message_filter.h"
@@ -41,13 +43,15 @@ namespace {
 
 class ContextMenuBrowserTest : public InProcessBrowserTest {
  public:
-  ContextMenuBrowserTest() { }
+  ContextMenuBrowserTest() {}
 
-  TestRenderViewContextMenu* CreateContextMenu(GURL unfiltered_url, GURL url) {
+  TestRenderViewContextMenu* CreateContextMenu(GURL unfiltered_url, GURL url,
+      blink::WebContextMenuData::MediaType media_type) {

[Alexei Svitkine (slow), 2015/02/20 18:37:27]

This doesn't follow style. Run "git cl format"?

[Not at Google. Contact bengr, 2015/02/21 00:11:17]

Done.

     content::ContextMenuParams params;
-    params.media_type = blink::WebContextMenuData::MediaTypeNone;
+    params.media_type = media_type;
     params.unfiltered_link_url = unfiltered_url;
     params.link_url = url;
+    params.src_url = url;
     WebContents* web_contents =
         browser()->tab_strip_model()->GetActiveWebContents();
     params.page_url = web_contents->GetController().GetActiveEntry()->GetURL();
@@ -62,6 +66,11 @@ class ContextMenuBrowserTest : public InProcessBrowserTest {
     menu->Init();
     return menu;
   }
+
+  TestRenderViewContextMenu* CreateContextMenu(GURL unfiltered_url, GURL url) {

[Alexei Svitkine (slow), 2015/02/20 18:37:27]

Pass params by const refs.

Same as above.

Also, give a different name as above, as overloads are discouraged.

[Not at Google. Contact bengr, 2015/02/21 00:11:16]

Done.

+    return CreateContextMenu(
+        unfiltered_url, url, blink::WebContextMenuData::MediaTypeNone);
+  }
 };
 
 IN_PROC_BROWSER_TEST_F(ContextMenuBrowserTest,
@@ -298,6 +307,46 @@ IN_PROC_BROWSER_TEST_F(ContextMenuBrowserTest, ViewPageInfoWithNoEntry) {
   menu.ExecuteCommand(IDC_CONTENT_CONTEXT_VIEWPAGEINFO, 0);
 }
 
+IN_PROC_BROWSER_TEST_F(ContextMenuBrowserTest, DataSaverOpenOrigImageInNewTab) {
+  base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
+  command_line->AppendSwitch(
+      data_reduction_proxy::switches::kEnableDataReductionProxy);
+
+  scoped_ptr<TestRenderViewContextMenu> menu(
+      CreateContextMenu(GURL(""),
+                        GURL("http://url.com/image.png"),
+                        blink::WebContextMenuData::MediaTypeImage));
+
+  ASSERT_FALSE(menu->IsItemPresent(IDC_CONTENT_CONTEXT_OPENIMAGENEWTAB));
+  ASSERT_TRUE(menu->IsItemPresent(IDC_CONTENT_CONTEXT_OPENORIGINALIMAGENEWTAB));
+}
+
+IN_PROC_BROWSER_TEST_F(ContextMenuBrowserTest,
+                       DataSaverHttpsOpenImageInNewTab) {
+  base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
+  command_line->AppendSwitch(
+      data_reduction_proxy::switches::kEnableDataReductionProxy);
+
+  scoped_ptr<TestRenderViewContextMenu> menu(
+      CreateContextMenu(GURL(""),
+                        GURL("https://url.com/image.png"),
+                        blink::WebContextMenuData::MediaTypeImage));
+
+  ASSERT_FALSE(
+      menu->IsItemPresent(IDC_CONTENT_CONTEXT_OPENORIGINALIMAGENEWTAB));
+  ASSERT_TRUE(menu->IsItemPresent(IDC_CONTENT_CONTEXT_OPENIMAGENEWTAB));
+}
+
+IN_PROC_BROWSER_TEST_F(ContextMenuBrowserTest, OpenImageInNewTab) {
+  scoped_ptr<TestRenderViewContextMenu> menu(
+      CreateContextMenu(GURL(""),
+                        GURL("http://url.com/image.png"),
+                        blink::WebContextMenuData::MediaTypeImage));
+  ASSERT_FALSE(
+      menu->IsItemPresent(IDC_CONTENT_CONTEXT_OPENORIGINALIMAGENEWTAB));
+  ASSERT_TRUE(menu->IsItemPresent(IDC_CONTENT_CONTEXT_OPENIMAGENEWTAB));
+}
+
 class ThumbnailResponseWatcher : public content::NotificationObserver {
  public:
   enum QuitReason {