Issue 944453002: Files.app: Fix broken js-comp by casting details panel to HTMLElement.

Issue 944453002: Files.app: Fix broken js-comp by casting details panel to HTMLElement. (Closed)

Created:
5 years, 10 months ago by Steve McKay

Modified:
5 years, 10 months ago

Reviewers:
Kyle Horimoto, Ben Kwa

CC:
chromium-reviews, tfarina, rginda+watch_chromium.org, mtomasz+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Files.app: Fix broken js-comp by casting details panel to HTMLElement. Committed: https://crrev.com/ca77486bc09177369238efc4830548a69ef40cc8 Cr-Commit-Position: refs/heads/master@{#317082}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	ui/file_manager/file_manager/foreground/js/import_controller.js	View		1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 13 (5 generated)

Steve McKay

Sorry. I forgot to check comp after applying the suggestion. Please tick the commit box.

5 years, 10 months ago (2015-02-19 17:47:38 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/944453002/1

5 years, 10 months ago (2015-02-19 17:51:06 UTC) #5

commit-bot: I haz the power

No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...

5 years, 10 months ago (2015-02-19 17:51:08 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/944453002/1

5 years, 10 months ago (2015-02-19 18:12:59 UTC) #11

commit-bot: I haz the power

5 years, 10 months ago (2015-02-19 18:47:26 UTC) #13

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/ca77486bc09177369238efc4830548a69ef40cc8
Cr-Commit-Position: refs/heads/master@{#317082}