chrome/browser/ui/browser_window_state.cc - Issue 944433002: Revamp the MigrateBrowserPrefs and MigrateUserPrefs code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_window_state.cc

Issue 944433002: Revamp the MigrateBrowserPrefs and MigrateUserPrefs code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: gab comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/browser_window_state.cc

diff --git a/chrome/browser/ui/browser_window_state.cc b/chrome/browser/ui/browser_window_state.cc

index f31e5ec984c1118306875d5c941d6f55af601ad7..dc224d10cab05c1589501ae8c589cb8485f9497f 100644

--- a/chrome/browser/ui/browser_window_state.cc

+++ b/chrome/browser/ui/browser_window_state.cc

@@ -70,8 +70,7 @@ class WindowPlacementPrefUpdate : public DictionaryPrefUpdate {

std::string GetWindowName(const Browser* browser) {

if (browser->app_name().empty()) {

- return browser->is_type_popup() ?

- prefs::kBrowserWindowPlacementPopup : prefs::kBrowserWindowPlacement;

+ return prefs::kBrowserWindowPlacementPopup;

rkaplow 2015/02/20 21:58:08 I'm not too sure about this. Can someone with cont

}

return browser->app_name();

}

« no previous file with comments | « chrome/browser/ui/browser_ui_prefs.cc ('k') | chrome/browser/ui/prefs/prefs_tab_helper.cc » ('j') | chrome/common/pref_names.h » ('J')