Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Unified Diff: chrome/browser/profiles/profile_impl.cc

Issue 944433002: Revamp the MigrateBrowserPrefs and MigrateUserPrefs code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: gab comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_impl.cc
diff --git a/chrome/browser/profiles/profile_impl.cc b/chrome/browser/profiles/profile_impl.cc
index 4fcb7e476868d7a0b1bcfdf970ca424aa082f8fc..def96c521a37ece6b7cd2f99c922286cccf1dd5e 100644
--- a/chrome/browser/profiles/profile_impl.cc
+++ b/chrome/browser/profiles/profile_impl.cc
@@ -855,10 +855,9 @@ void ProfileImpl::OnPrefsLoaded(bool success) {
return;
}
- // TODO(mirandac): remove migration code after 6 months (crbug.com/69995).
+ // Migrate all obsolete prefs.
gab 2015/02/20 20:33:57 rm "all" (it's implicit IMO) PS: I like "obsolete
rkaplow 2015/02/20 21:58:08 Seems fine. Note that some of the work is done by
if (g_browser_process->local_state())
chrome::MigrateBrowserPrefs(this, g_browser_process->local_state());
- // TODO(ivankr): remove cleanup code eventually (crbug.com/165672).
chrome::MigrateUserPrefs(this);
// |kSessionExitType| was added after |kSessionExitedCleanly|. If the pref
« chrome/browser/prefs/browser_prefs.cc ('K') | « chrome/browser/prefs/browser_prefs.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698